Skip to content

setup/install_deps.sh fails: (a) while resolving directory path to config_explorer and (b) if there are space characters in directory paths #665

@vknaik

Description

@vknaik

Component

Setup/Standup

Describe the bug

Description

The setup/install_deps.sh script fails:

  1. while installing config_explorer component because of incorrect resolution of directory path to config_explorer directory and
  2. when the path to the repository contains spaces due to unquoted variables in the script

Steps to reproduce

Steps to Reproduce

  1. Clone repository to a path with spaces (e.g., /path/with spaces/llm-d-benchmark)
  2. Run ./setup/install_deps.sh
  3. Script fails with errors about missing directories
  4. Script also fails while resolving directory path to config_explorer even if there are no space characters in the path variables

Additional context or screenshots

Root Causes

  1. Unquoted path variables cause word splitting
  2. LLMDBENCH_INSTALLDEPS_DIR incorrectly resolves to repository root instead of setup directory
  3. config_explorer installation fails due to incorrect path resolution

Affected Files

  • setup/install_deps.sh

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions