Raise coverage (#304)

* Raise coverage
* Options tests added

Author: lloc

includes/MslsOptions.php

@@ -323,16 +323,16 @@ public function get_url( $dir ) {
 	/**
 	 * Returns slug for a post type
 	 *
+	 * @todo This method is not used anywhere in the codebase. Should it be removed?
+	 *
 	 * @param string $post_type
 	 *
 	 * @return string
 	 */
-	public function get_slug( $post_type ) {
+	public function get_slug( string $post_type ): string {
 		$key = "rewrite_{$post_type}";
 
-		error_log( $key );
-
-		return isset( $this->$key ) ? $this->$key : '';
+		return $this->$key ?? '';
 	}
 
 	/**
@@ -352,11 +352,7 @@ public function get_icon( $language ) {
 	 * @return string
 	 */
 	public function get_flag_url( $language ) {
-		if ( ! is_admin() && isset( $this->image_url ) ) {
-			$url = $this->__get( 'image_url' );
-		} else {
-			$url = $this->get_url( 'flags' );
-		}
+		$url = ! is_admin() && isset( $this->image_url ) ? $this->__get( 'image_url' ) : $this->get_url( 'flags' );
 
 		/**
 		 * Override the path to the flag-icons

includes/MslsOptionsQueryPostType.php

@@ -1,6 +1,7 @@
 <?php
 /**
  * MslsOptionsQueryPostType
+ *
  * @author Dennis Ploetner <[email protected]>
  * @since 0.9.8
  */
@@ -15,7 +16,7 @@
 class MslsOptionsQueryPostType extends MslsOptionsQuery {
 
 	/**
-	 * Check if the array has an non empty item which has $language as a key
+	 * Check if the array has a non-empty item which has $language as a key
 	 *
 	 * @param string $language
 	 *
@@ -37,5 +38,4 @@ public function has_value( $language ) {
 	public function get_current_link() {
 		return (string) get_post_type_archive_link( $this->get_arg( 0, '' ) );
 	}
-
 }

includes/MslsOptionsQueryYear.php

@@ -1,6 +1,7 @@
 <?php
 /**
  * MslsOptionsQueryYear
+ *
  * @author Dennis Ploetner <[email protected]>
  * @since 0.9.8
  */
@@ -15,7 +16,7 @@
 class MslsOptionsQueryYear extends MslsOptionsQuery {
 
 	/**
-	 * Check if the array has an non empty item which has $language as a key
+	 * Check if the array has a non-empty item which has $language as a key
 	 *
 	 * @param string $language
 	 *
@@ -44,5 +45,4 @@ public function has_value( $language ) {
 	public function get_current_link() {
 		return get_year_link( $this->get_arg( 0, 0 ) );
 	}
-
 }

tests/TestMslsOptions.php

@@ -4,13 +4,14 @@
 
 use Brain\Monkey\Functions;
 
+use lloc\Msls\MslsAdminIcon;
 use lloc\Msls\MslsOptions;
 
 class TestMslsOptions extends MslsUnitTestCase {
 
 	public function get_test(): MslsOptions {
 		Functions\when( 'home_url' )->justReturn( 'https://lloc.de' );
-		Functions\when( 'get_option' )->justReturn( [] );
+		Functions\when( 'get_option' )->justReturn( array() );
 		Functions\when( 'update_option' )->justReturn( true );
 
 		return new MslsOptions();
@@ -36,9 +37,9 @@ public function test_is_query_page_method(): void {
 
 	public function test_create_method(): void {
 		Functions\when( 'is_admin' )->justReturn( true );
-		Functions\when( 'get_post_types' )->justReturn( [] );
+		Functions\when( 'get_post_types' )->justReturn( array() );
 		Functions\when( 'get_post_type' )->justReturn( 'post' );
-		Functions\when( 'get_option' )->justReturn( [] );
+		Functions\when( 'get_option' )->justReturn( array() );
 
 		$this->assertInstanceOf( MslsOptions::class, MslsOptions::create() );
 	}
@@ -49,14 +50,23 @@ public function test_get_arg_method(): void {
 		$this->assertNull( $obj->get_arg( 0 ) );
 		$this->assertIsSTring( $obj->get_arg( 0, '' ) );
 		$this->assertIsFloat( $obj->get_arg( 0, 1.1 ) );
-		$this->assertIsArray( $obj->get_arg( 0, [] ) );
+		$this->assertIsArray( $obj->get_arg( 0, array() ) );
 	}
 
 	function test_set_method(): void {
 		$obj = $this->get_test();
 
-		$this->assertTrue( $obj->set( [] ) );
-		$this->assertTrue( $obj->set( array( 'temp' => 'abc' ) ) );
+		$this->assertTrue( $obj->set( array() ) );
+		$this->assertTrue(
+			$obj->set(
+				array(
+					'temp' => 'abc',
+					'en'   => 1,
+					'us'   => 2,
+				)
+			)
+		);
+
 		$this->assertFalse( $obj->set( 'Test' ) );
 		$this->assertFalse( $obj->set( 1 ) );
 		$this->assertFalse( $obj->set( 1.1 ) );
@@ -120,11 +130,37 @@ function test_get_flag_url_method(): void {
 	}
 
 	function test_get_available_languages_method(): void {
-		Functions\when( 'get_available_languages' )->justReturn( [] );
+		Functions\expect( 'get_available_languages' )->once()->andReturn( array( 'de_DE', 'it_IT' ) );
+		Functions\expect( 'format_code_lang' )->atLeast()->once()->andReturnUsing(
+			function ( $code ) {
+				$map = array(
+					'de_DE' => 'German',
+					'it_IT' => 'Italian',
+				);
+				return $map[ $code ] ?? 'American English';
+			}
+		);
+
+		$obj = $this->get_test();
+
+		$expected = array(
+			'en_US' => 'American English',
+			'de_DE' => 'German',
+			'it_IT' => 'Italian',
+		);
+		$this->assertEquals( $expected, $obj->get_available_languages() );
+	}
 
+	public function test_get_icon_type_standard(): void {
 		$obj = $this->get_test();
 
-		$this->assertIsArray( $obj->get_available_languages() );
+		$this->assertEquals( MslsAdminIcon::TYPE_FLAG, $obj->get_icon_type() );
 	}
 
+	public function test_get_icon_type_admin_display(): void {
+		$obj = $this->get_test();
+		$obj->set( array( 'admin_display' => MslsAdminIcon::TYPE_LABEL ) );
+
+		$this->assertEquals( MslsAdminIcon::TYPE_LABEL, $obj->get_icon_type() );
+	}
 }