Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] more strict connect semantic #8069

Open
sequencer opened this issue Jan 12, 2025 · 1 comment
Open

[FIRRTL] more strict connect semantic #8069

sequencer opened this issue Jan 12, 2025 · 1 comment

Comments

@sequencer
Copy link
Contributor

I observe that, the current firrtl.connect only checks the src width not larger than the dst width, but not vice versa. since in the firrtl parser logic we already define some the padding and truncate logic, we can make firrtl.connect be more strict, e.g. checking width exactly same to find width bug in the early phase.

@sequencer sequencer changed the title more strict connect semantic [FIRRTL] more strict connect semantic Jan 12, 2025
@darthscsi
Copy link
Contributor

strictconnect has those semantics. connect is essentially dead through the pipeline and exists for parsing and fixing up the padding and truncation early on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants