Skip to content

Commit 13c7617

Browse files
[Vectorize] Fix warnings
This patch fixes: third-party/unittest/googletest/include/gtest/gtest.h:1379:11: error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/InstrMaps.h:57:12: error: unused variable 'Pair' [-Werror,-Wunused-variable]
1 parent 8942d5e commit 13c7617

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/InstrMaps.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class InstrMaps {
5656
for (auto [Lane, Orig] : enumerate(Origs)) {
5757
auto Pair = OrigToVectorMap.try_emplace(Orig, Vec);
5858
assert(Pair.second && "Orig already exists in the map!");
59+
(void)Pair;
5960
OrigToLaneMap[Orig] = Lane;
6061
}
6162
}

llvm/unittests/Transforms/Vectorize/SandboxVectorizer/InstrMapsTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ define void @foo(i8 %v0, i8 %v1, i8 %v2, i8 %v3, <2 x i8> %vec) {
6464
EXPECT_EQ(IMaps.getVectorForOrig(Add1), VAdd0);
6565
EXPECT_FALSE(IMaps.getOrigLane(VAdd0, VAdd0)); // Bad Orig value
6666
EXPECT_FALSE(IMaps.getOrigLane(Add0, Add0)); // Bad Vector value
67-
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add0), 0);
68-
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add1), 1);
67+
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add0), 0U);
68+
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add1), 1U);
6969
// Check when the same vector maps to different original values (which is
7070
// common for vector constants).
7171
IMaps.registerVector({Add2, Add3}, VAdd0);
72-
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add2), 0);
73-
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add3), 1);
72+
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add2), 0U);
73+
EXPECT_EQ(*IMaps.getOrigLane(VAdd0, Add3), 1U);
7474
// Check when we register for a second time.
7575
#ifndef NDEBUG
7676
EXPECT_DEATH(IMaps.registerVector({Add1, Add0}, VAdd0), ".*exists.*");

0 commit comments

Comments
 (0)