Skip to content

Commit 2bb763f

Browse files
committedApr 14, 2025·
AMDGPU/GlobalISel: add RegBankLegalize rules for select
Uniform condition S1 is AnyExtended to S32 and high bits are cleaned using AND with 1. Divergent S1 uses VCC. Using B32/B64 rules to cover scalars vector and pointer types. Divergent B64 is split to S32.
1 parent c57e522 commit 2bb763f

File tree

5 files changed

+654
-1280
lines changed

5 files changed

+654
-1280
lines changed
 

Diff for: ‎llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeHelper.cpp

+21-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "llvm/CodeGen/GlobalISel/MachineIRBuilder.h"
2222
#include "llvm/CodeGen/MachineUniformityAnalysis.h"
2323
#include "llvm/IR/IntrinsicsAMDGPU.h"
24+
#include "llvm/Support/AMDGPUAddrSpace.h"
2425

2526
#define DEBUG_TYPE "amdgpu-regbanklegalize"
2627

@@ -294,6 +295,22 @@ void RegBankLegalizeHelper::lowerSplitTo32(MachineInstr &MI) {
294295
MI.eraseFromParent();
295296
}
296297

298+
void RegBankLegalizeHelper::lowerSplitTo32Sel(MachineInstr &MI) {
299+
Register Dst = MI.getOperand(0).getReg();
300+
LLT Ty = MRI.getType(Dst) == V4S16 ? V2S16 : S32;
301+
auto Op2 = B.buildUnmerge({VgprRB, Ty}, MI.getOperand(2).getReg());
302+
auto Op3 = B.buildUnmerge({VgprRB, Ty}, MI.getOperand(3).getReg());
303+
Register Cond = MI.getOperand(1).getReg();
304+
auto Flags = MI.getFlags();
305+
auto Lo =
306+
B.buildSelect({VgprRB, Ty}, Cond, Op2.getReg(0), Op3.getReg(0), Flags);
307+
auto Hi =
308+
B.buildSelect({VgprRB, Ty}, Cond, Op2.getReg(1), Op3.getReg(1), Flags);
309+
310+
B.buildMergeLikeInstr(Dst, {Lo, Hi});
311+
MI.eraseFromParent();
312+
}
313+
297314
void RegBankLegalizeHelper::lower(MachineInstr &MI,
298315
const RegBankLLTMapping &Mapping,
299316
SmallSet<Register, 4> &WaterfallSgprs) {
@@ -380,6 +397,8 @@ void RegBankLegalizeHelper::lower(MachineInstr &MI,
380397
return lowerUni_BFE(MI);
381398
case SplitTo32:
382399
return lowerSplitTo32(MI);
400+
case SplitTo32Sel:
401+
return lowerSplitTo32Sel(MI);
383402
case SplitLoad: {
384403
LLT DstTy = MRI.getType(MI.getOperand(0).getReg());
385404
unsigned Size = DstTy.getSizeInBits();
@@ -493,7 +512,8 @@ LLT RegBankLegalizeHelper::getBTyFromID(RegBankLLTMappingApplyID ID, LLT Ty) {
493512
case UniInVgprB64:
494513
if (Ty == LLT::scalar(64) || Ty == LLT::fixed_vector(2, 32) ||
495514
Ty == LLT::fixed_vector(4, 16) || Ty == LLT::pointer(0, 64) ||
496-
Ty == LLT::pointer(1, 64) || Ty == LLT::pointer(4, 64))
515+
Ty == LLT::pointer(1, 64) || Ty == LLT::pointer(4, 64) ||
516+
(Ty.isPointer() && Ty.getAddressSpace() > AMDGPUAS::MAX_AMDGPU_ADDRESS))
497517
return Ty;
498518
return LLT();
499519
case SgprB96:

Diff for: ‎llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeHelper.h

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ class RegBankLegalizeHelper {
114114
void lowerDiv_BFE(MachineInstr &MI);
115115
void lowerUni_BFE(MachineInstr &MI);
116116
void lowerSplitTo32(MachineInstr &MI);
117+
void lowerSplitTo32Sel(MachineInstr &MI);
117118
};
118119

119120
} // end namespace AMDGPU

Diff for: ‎llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp

+7-2
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ UniformityLLTOpPredicateID LLTToBId(LLT Ty) {
198198
return B32;
199199
if (Ty == LLT::scalar(64) || Ty == LLT::fixed_vector(2, 32) ||
200200
Ty == LLT::fixed_vector(4, 16) || Ty == LLT::pointer(1, 64) ||
201-
Ty == LLT::pointer(4, 64))
201+
Ty == LLT::pointer(4, 64) ||
202+
(Ty.isPointer() && Ty.getAddressSpace() > AMDGPUAS::MAX_AMDGPU_ADDRESS))
202203
return B64;
203204
if (Ty == LLT::fixed_vector(3, 32))
204205
return B96;
@@ -485,8 +486,12 @@ RegBankLegalizeRules::RegBankLegalizeRules(const GCNSubtarget &_ST,
485486
addRulesForGOpcs({G_BR}).Any({{_}, {{}, {None}}});
486487

487488
addRulesForGOpcs({G_SELECT}, StandardB)
489+
.Any({{DivS16}, {{Vgpr16}, {Vcc, Vgpr16, Vgpr16}}})
490+
.Any({{UniS16}, {{Sgpr16}, {Sgpr32AExtBoolInReg, Sgpr16, Sgpr16}}})
488491
.Div(B32, {{VgprB32}, {Vcc, VgprB32, VgprB32}})
489-
.Uni(B32, {{SgprB32}, {Sgpr32AExtBoolInReg, SgprB32, SgprB32}});
492+
.Uni(B32, {{SgprB32}, {Sgpr32AExtBoolInReg, SgprB32, SgprB32}})
493+
.Div(B64, {{VgprB64}, {Vcc, VgprB64, VgprB64}, SplitTo32Sel})
494+
.Uni(B64, {{SgprB64}, {Sgpr32AExtBoolInReg, SgprB64, SgprB64}});
490495

491496
addRulesForGOpcs({G_ANYEXT})
492497
.Any({{UniS16, S1}, {{None}, {None}}}) // should be combined away

Diff for: ‎llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.h

+1
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ enum LoweringMethodID {
177177
Div_BFE,
178178
VgprToVccCopy,
179179
SplitTo32,
180+
SplitTo32Sel,
180181
Ext32To64,
181182
UniCstExt,
182183
SplitLoad,

Diff for: ‎llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir

+624-1,277
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Please sign in to comment.