Skip to content

Commit b9297dc

Browse files
nemanja-ibmtstellar
authored andcommitted
[PowerPC] Do not emit HW loop if the body contains calls to lrint/lround
These two intrinsics are lowered to calls so should prevent the formation of CTR loops. In a subsequent patch, we will handle all currently known intrinsics and prevent the formation of HW loops if any unknown intrinsics are encountered. Differential revision: https://reviews.llvm.org/D68841 (cherry picked from commit 97e3626)
1 parent 98b1752 commit b9297dc

File tree

2 files changed

+79
-0
lines changed

2 files changed

+79
-0
lines changed

llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,12 @@ bool PPCTTIImpl::mightUseCTR(BasicBlock *BB,
331331
case Intrinsic::ceil: Opcode = ISD::FCEIL; break;
332332
case Intrinsic::trunc: Opcode = ISD::FTRUNC; break;
333333
case Intrinsic::rint: Opcode = ISD::FRINT; break;
334+
case Intrinsic::lrint: Opcode = ISD::LRINT; break;
335+
case Intrinsic::llrint: Opcode = ISD::LLRINT; break;
334336
case Intrinsic::nearbyint: Opcode = ISD::FNEARBYINT; break;
335337
case Intrinsic::round: Opcode = ISD::FROUND; break;
338+
case Intrinsic::lround: Opcode = ISD::LROUND; break;
339+
case Intrinsic::llround: Opcode = ISD::LLROUND; break;
336340
case Intrinsic::minnum: Opcode = ISD::FMINNUM; break;
337341
case Intrinsic::maxnum: Opcode = ISD::FMAXNUM; break;
338342
case Intrinsic::umul_with_overflow: Opcode = ISD::UMULO; break;

llvm/test/CodeGen/PowerPC/pr43527.ll

+75
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
2+
; RUN: llc -ppc-asm-full-reg-names -verify-machineinstrs \
3+
; RUN: -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 < %s | FileCheck %s
4+
; We don't want to produce a CTR loop due to the call to lrint in the body.
5+
define dso_local void @test(i64 %arg, i64 %arg1) {
6+
; CHECK-LABEL: test:
7+
; CHECK: # %bb.0: # %bb
8+
; CHECK-NEXT: bc 4, 4*cr5+lt, .LBB0_5
9+
; CHECK-NEXT: # %bb.1: # %bb3
10+
; CHECK-NEXT: bc 12, 4*cr5+lt, .LBB0_6
11+
; CHECK-NEXT: # %bb.2: # %bb4
12+
; CHECK-NEXT: mflr r0
13+
; CHECK-NEXT: .cfi_def_cfa_offset 64
14+
; CHECK-NEXT: .cfi_offset lr, 16
15+
; CHECK-NEXT: .cfi_offset r29, -24
16+
; CHECK-NEXT: .cfi_offset r30, -16
17+
; CHECK-NEXT: std r29, -24(r1) # 8-byte Folded Spill
18+
; CHECK-NEXT: std r30, -16(r1) # 8-byte Folded Spill
19+
; CHECK-NEXT: std r0, 16(r1)
20+
; CHECK-NEXT: stdu r1, -64(r1)
21+
; CHECK-NEXT: sub r30, r4, r3
22+
; CHECK-NEXT: li r29, 0
23+
; CHECK-NEXT: .p2align 5
24+
; CHECK-NEXT: .LBB0_3: # %bb5
25+
; CHECK-NEXT: #
26+
; CHECK-NEXT: lfsx f1, 0, r29
27+
; CHECK-NEXT: bl lrint
28+
; CHECK-NEXT: nop
29+
; CHECK-NEXT: addi r30, r30, -1
30+
; CHECK-NEXT: addi r29, r29, 4
31+
; CHECK-NEXT: cmpldi r30, 0
32+
; CHECK-NEXT: bne cr0, .LBB0_3
33+
; CHECK-NEXT: # %bb.4: # %bb15
34+
; CHECK-NEXT: stb r3, 0(r3)
35+
; CHECK-NEXT: addi r1, r1, 64
36+
; CHECK-NEXT: ld r0, 16(r1)
37+
; CHECK-NEXT: mtlr r0
38+
; CHECK-NEXT: ld r30, -16(r1) # 8-byte Folded Reload
39+
; CHECK-NEXT: ld r29, -24(r1) # 8-byte Folded Reload
40+
; CHECK-NEXT: blr
41+
; CHECK-NEXT: .LBB0_5: # %bb2
42+
; CHECK-NEXT: .LBB0_6: # %bb14
43+
bb:
44+
br i1 undef, label %bb3, label %bb2
45+
46+
bb2: ; preds = %bb
47+
unreachable
48+
49+
bb3: ; preds = %bb
50+
%tmp = sub i64 %arg1, %arg
51+
br i1 undef, label %bb4, label %bb14
52+
53+
bb4: ; preds = %bb3
54+
br label %bb5
55+
56+
bb5: ; preds = %bb5, %bb4
57+
%tmp6 = phi i64 [ %tmp12, %bb5 ], [ 0, %bb4 ]
58+
%tmp7 = getelementptr inbounds float, float* null, i64 %tmp6
59+
%tmp8 = load float, float* %tmp7, align 4
60+
%tmp9 = fpext float %tmp8 to double
61+
%tmp10 = tail call i64 @llvm.lrint.i64.f64(double %tmp9) #2
62+
%tmp11 = trunc i64 %tmp10 to i8
63+
store i8 %tmp11, i8* undef, align 1
64+
%tmp12 = add nuw i64 %tmp6, 1
65+
%tmp13 = icmp eq i64 %tmp12, %tmp
66+
br i1 %tmp13, label %bb15, label %bb5
67+
68+
bb14: ; preds = %bb3
69+
unreachable
70+
71+
bb15: ; preds = %bb5
72+
ret void
73+
}
74+
75+
declare i64 @llvm.lrint.i64.f64(double)

0 commit comments

Comments
 (0)