Skip to content

Commit de4663f

Browse files
committed
[SelectionDAG] Allow vselect in foldBinOpIntoSelect
It seems vselect was also meant to be an option given the comment and the fact vectors are allowed and the kind is checked too.
1 parent a23bd17 commit de4663f

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2490,7 +2490,8 @@ SDValue DAGCombiner::foldBinOpIntoSelect(SDNode *BO) {
24902490
unsigned SelOpNo = 0;
24912491
SDValue Sel = BO->getOperand(0);
24922492
auto BinOpcode = BO->getOpcode();
2493-
if (Sel.getOpcode() != ISD::SELECT || !Sel.hasOneUse()) {
2493+
if ((Sel.getOpcode() != ISD::SELECT && Sel.getOpcode() != ISD::VSELECT) ||
2494+
!Sel.hasOneUse()) {
24942495
SelOpNo = 1;
24952496
Sel = BO->getOperand(1);
24962497

@@ -2506,7 +2507,8 @@ SDValue DAGCombiner::foldBinOpIntoSelect(SDNode *BO) {
25062507
}
25072508
}
25082509

2509-
if (Sel.getOpcode() != ISD::SELECT || !Sel.hasOneUse())
2510+
if ((Sel.getOpcode() != ISD::SELECT && Sel.getOpcode() != ISD::VSELECT) ||
2511+
!Sel.hasOneUse())
25102512
return SDValue();
25112513

25122514
SDValue CT = Sel.getOperand(1);

llvm/test/CodeGen/X86/extract-vselect-setcc.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ define void @PR117684(i1 %cond, <8 x float> %vec, ptr %ptr1, ptr %ptr2) #0 {
55
; CHECK-LABEL: PR117684:
66
; CHECK: # %bb.0:
77
; CHECK-NEXT: vxorps %xmm1, %xmm1, %xmm1
8-
; CHECK-NEXT: vcmpnltss %xmm1, %xmm0, %k1
9-
; CHECK-NEXT: vbroadcastss {{.*#+}} xmm0 = [NaN,NaN,NaN,NaN]
10-
; CHECK-NEXT: vinsertf32x4 $0, %xmm0, %ymm0, %ymm0 {%k1} {z}
11-
; CHECK-NEXT: vmulss %xmm1, %xmm0, %xmm0
12-
; CHECK-NEXT: vmulss {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %xmm2
8+
; CHECK-NEXT: vmovss {{.*#+}} xmm2 = [NaN,0.0E+0,0.0E+0,0.0E+0]
9+
; CHECK-NEXT: vcmpltss %xmm1, %xmm0, %k1
10+
; CHECK-NEXT: vmovaps %xmm2, %xmm0
11+
; CHECK-NEXT: vmovss %xmm1, %xmm0, %xmm0 {%k1}
12+
; CHECK-NEXT: vmulss %xmm2, %xmm0, %xmm2
1313
; CHECK-NEXT: vbroadcastss %xmm2, %ymm2
1414
; CHECK-NEXT: testb $1, %dil
1515
; CHECK-NEXT: cmoveq %rdx, %rsi

0 commit comments

Comments
 (0)