Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1353R0: Missing feature test macros #100006

Closed
cjdb opened this issue Jul 22, 2024 · 4 comments · Fixed by #123020
Closed

P1353R0: Missing feature test macros #100006

cjdb opened this issue Jul 22, 2024 · 4 comments · Fixed by #123020
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev wg21 paper Issues representing the implementation of a WG21 paper

Comments

@cjdb
Copy link
Contributor

cjdb commented Jul 22, 2024

Link: https://wg21.link/p1353r0

Related to #99986.

@cjdb cjdb added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. c++20 labels Jul 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 22, 2024

@llvm/issue-subscribers-c-20

Author: Christopher Di Bella (cjdb)

Related to #99986.

@cjdb cjdb added the good first issue https://github.com/llvm/llvm-project/contribute label Jul 24, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2024

@llvm/issue-subscribers-good-first-issue

Author: Christopher Di Bella (cjdb)

Related to #99986.

@ldionne ldionne added the wg21 paper Issues representing the implementation of a WG21 paper label Jul 30, 2024
@cjdb cjdb added potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev and removed good first issue https://github.com/llvm/llvm-project/contribute labels Aug 1, 2024
@ldionne ldionne changed the title Complete 'P1353R0 Missing feature test macros' P1353R0: Missing feature test macros Aug 1, 2024
@ldionne ldionne moved this from Todo to In Progress in libc++ Standards Conformance Aug 21, 2024
@frederick-vs-ja
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. potentially good for outreach Consider this issue as a good first issue for someone that has spoken to an experienced LLVM dev wg21 paper Issues representing the implementation of a WG21 paper
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants