-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL] Add StructuredBuffer
definition to HLSLExternalSemaSource
#106189
Labels
Comments
bob80905
added a commit
that referenced
this issue
Sep 11, 2024
This PR adds `StructuredBuffer` to `HLSLExternalSemaSource.cpp`, by copying the logic from RWBuffer but just replacing the name with StructuredBuffer. The change now allows StructuredBuffers to be defined in HLSL, though they function the same as RWBuffers. Further work to apply the appropriate attributes that distinguish StructuredBuffers from other Buffer types will be deferred. This improves our position on #106189
Blocked on llvm/wg-hlsl#68. |
Fixed by #106316 |
StructuredBuffer
definition to HLSLExternalSemaSource
@llvm/issue-subscribers-clang-frontend Author: Justin Bogner (bogner)
Create the `StructuredBuffer` template in HLSLExternalSemaSource, which each contain a handle that will be lowered to a `dx.RawBuffer` target extension type with a struct as their type argument.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Create the
StructuredBuffer
template in HLSLExternalSemaSource, which each contain a handle that will be lowered to adx.RawBuffer
target extension type with a struct as their type argument.The text was updated successfully, but these errors were encountered: