Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Add StructuredBuffer definition to HLSLExternalSemaSource #106189

Closed
Tracked by #88
bogner opened this issue Aug 27, 2024 · 3 comments
Closed
Tracked by #88

[HLSL] Add StructuredBuffer definition to HLSLExternalSemaSource #106189

bogner opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@bogner
Copy link
Contributor

bogner commented Aug 27, 2024

Create the StructuredBuffer template in HLSLExternalSemaSource, which each contain a handle that will be lowered to a dx.RawBuffer target extension type with a struct as their type argument.

@bogner bogner changed the title Add StructuredBuffer definitions to HLSLExternalSemaSource [HLSL] Add StructuredBuffer definitions to HLSLExternalSemaSource Aug 27, 2024
@bogner bogner transferred this issue from llvm/wg-hlsl Aug 27, 2024
@bogner bogner added the HLSL HLSL Language Support label Aug 27, 2024
@bob80905 bob80905 self-assigned this Aug 27, 2024
bob80905 added a commit that referenced this issue Sep 11, 2024
This PR adds `StructuredBuffer` to `HLSLExternalSemaSource.cpp`, by
copying the logic from RWBuffer but just replacing the name with
StructuredBuffer. The change now allows StructuredBuffers to be defined
in HLSL, though they function the same as RWBuffers.

Further work to apply the appropriate attributes that distinguish
StructuredBuffers from other Buffer types will be deferred.
This improves our position on
#106189
@damyanp
Copy link
Contributor

damyanp commented Sep 17, 2024

Blocked on llvm/wg-hlsl#68.

@damyanp damyanp moved this to Active in HLSL Support Oct 9, 2024
@hekota
Copy link
Member

hekota commented Oct 17, 2024

Fixed by #106316

@hekota hekota closed this as completed Oct 17, 2024
@hekota hekota changed the title [HLSL] Add StructuredBuffer definitions to HLSLExternalSemaSource [HLSL] Add StructuredBuffer definition to HLSLExternalSemaSource Oct 17, 2024
@EugeneZelenko EugeneZelenko added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Oct 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2024

@llvm/issue-subscribers-clang-frontend

Author: Justin Bogner (bogner)

Create the `StructuredBuffer` template in HLSLExternalSemaSource, which each contain a handle that will be lowered to a `dx.RawBuffer` target extension type with a struct as their type argument.

@damyanp damyanp removed the status in HLSL Support Oct 22, 2024
@hekota hekota moved this to Planning in HLSL Support Oct 24, 2024
@hekota hekota moved this from Planning to Closed in HLSL Support Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
Archived in project
Development

No branches or pull requests

6 participants