-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL] Generate AST for Root Signatures #119011
Comments
Self-note for information regarding default values: https://learn.microsoft.com/en-us/windows/win32/direct3d12/specifying-root-signatures-in-hlsl |
Feedback from refinement: split this into two issues - one for parsing the root signature string, and then another for adding the attribute and hooking it into the parser. |
Needs some information about how ast-dump will be modified to allow for testing. |
…ureAttr` (#134124) - Defines HLSLRootSignature Attr in `Attr.td` - Define and implement handleHLSLRootSignature in `SemaHLSL` - Adds sample test case to show AST Node is generated in `RootSignatures-AST.hlsl` This commit will "hook-up" the seperately defined RootSignature parser and invoke it to create the RootElements, then store them on the ASTContext and finally store the reference to the Elements in RootSignatureAttr Resolves llvm/llvm-project#119011 --------- Co-authored-by: Finn Plummer <[email protected]>
@llvm/issue-subscribers-clang-frontend Author: Finn Plummer (inbelic)
This issue handles "plugging-in" the root signature parser into the generation of the AST node. It consists of initializing an `HLSLRootSignatureAttr` with the parsed `HLSLRootElements`.
Root signatures are defined as a list of "root elements" and so the in-memory representation will retain this form. This is dependent on #120472. AC:
|
This issue handles "plugging-in" the root signature parser into the generation of the AST node. It consists of initializing an
HLSLRootSignatureAttr
with the parsedHLSLRootElements
.Root signatures are defined as a list of "root elements" and so the in-memory representation will retain this form.
This is dependent on #120472.
AC:
HLSLRootSignatureAttr
inAttr.td
AdditionalMembers
to hold an ArrayRef ofHLSLRootElement
shandleHLSLRootSignature
inSemaHLSL.h
handleHLSLRootSignature
inSemaHLSL.cpp
to simply invoke the parser and construct the Root Elements on the ASTContext, then set theAdditionalMembers
to refence thatast-dump
inAST/HLSL/RootSignatures-AST.hlsl
The text was updated successfully, but these errors were encountered: