[HLSL] Implement Root Signature Lexer for Descriptor Tables #126563
Assignees
Labels
Comments
This was referenced Feb 10, 2025
EugeneZelenko
added
the
clang:frontend
|
@llvm/issue-subscribers-clang-frontend Author: Finn Plummer (inbelic)
This issue handles the lexing of a root signature string into a token representation of the data. Specifically, it handles and defines all the tokens required for a Descriptor Table and its clauses.
For the sake of scope, we will let the lexing of floating literals be deferred until needed for Static Samplers. Other than that this pr should allow us to simply define new enumerations/keywords in AC:
|
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this issue
Feb 14, 2025
For the sake of scope, we will let the lexing of floating literals be deferred until needed for Static Samplers. Other than that this pr should allow us to simply define new enumerations/keywords in `RootSignatureTokenKinds.def` for when they are used in the parser. We could have defined all of these keywords here, but for the sake of correctness in review we will let them be split up. - Define `RootSignatureLexer` and provide a public `LexToken` method for external use - Define the file `RootSignatureTokenKinds` to define required tokens and allow for future custom keywords/enums - Implement the internal methods required to parse the different types of tokens (integers, flag enums, puncuators...) - Add test harness for unit testing and the respective unit tests for lexing the tokens Resolves llvm#126563 --------- Co-authored-by: Chris B <[email protected]>
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this issue
Feb 24, 2025
For the sake of scope, we will let the lexing of floating literals be deferred until needed for Static Samplers. Other than that this pr should allow us to simply define new enumerations/keywords in `RootSignatureTokenKinds.def` for when they are used in the parser. We could have defined all of these keywords here, but for the sake of correctness in review we will let them be split up. - Define `RootSignatureLexer` and provide a public `LexToken` method for external use - Define the file `RootSignatureTokenKinds` to define required tokens and allow for future custom keywords/enums - Implement the internal methods required to parse the different types of tokens (integers, flag enums, puncuators...) - Add test harness for unit testing and the respective unit tests for lexing the tokens Resolves llvm#126563 --------- Co-authored-by: Chris B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue handles the lexing of a root signature string into a token representation of the data. Specifically, it handles and defines all the tokens required for a Descriptor Table and its clauses.
For the sake of scope, we will let the lexing of floating literals be deferred until needed for Static Samplers. Other than that this pr should allow us to simply define new enumerations/keywords in
RootSignatureTokenKinds.deffor when they are used in the parser. We could have define all of these keywords here, but for the sake of correctness in review we will let them be split up.AC:
RootSignatureLexerand provide a publicLexTokenmethod for external useRootSignatureTokenKindsto define required tokens and allow for future custom keywords/enumsThe text was updated successfully, but these errors were encountered: