Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] Implement the Root Signature Parser for Descriptor Tables #126569

Open
4 tasks
inbelic opened this issue Feb 10, 2025 · 0 comments
Open
4 tasks

[HLSL] Implement the Root Signature Parser for Descriptor Tables #126569

inbelic opened this issue Feb 10, 2025 · 0 comments
Assignees
@inbelic
Labels
HLSL HLSL Language Support

Comments

@inbelic
Copy link
Contributor

inbelic commented Feb 10, 2025 •
edited
Loading

This issues handles the implementation of parsing the root signature in its token form into the in-memory representation of RootElements. Specifically, it handles all Descriptor Table related tokens and parses these into the DescriptorTable and DescriptorTableClause struct representation.

This will define all the helper methods of Root Signature Parser needed for the other Root Element types and so it constitutes the "first 90%" of work for implementing the complete parser.

Note that this parser definition will be completely self-contained and can be invoked externally when creating the HLSLRootSignatureAttr

This issue is dependent on #126563

AC:

  • Define the in-memory representation of RootElement, DescriptorTable and DescriptorTableClause in HLSLRootSignatures.h
  • Define RootSignatureParser and provide a public Parse that will take an input RootSignatureLexer and generate a list of RootElements
  • Implement the internal methods and helper methods required to parse the different types of RootElements
  • Add unit testing in ParseHLSLRootSignatureTest.cpp
@inbelic inbelic added the HLSL HLSL Language Support label Feb 10, 2025
@inbelic inbelic self-assigned this Feb 10, 2025
This was referenced Feb 10, 2025
Closed
Open
Open
Open
@inbelic inbelic moved this to Planning in HLSL Support Feb 10, 2025
@inbelic inbelic mentioned this issue Feb 10, 2025
Open
7 tasks
@inbelic inbelic linked a pull request Feb 10, 2025 that will close this issue
[HLSL][RootSignature] Implement Parsing of Descriptor Tables #122982
Closed
@damyanp damyanp moved this from Planning to Needs Review in HLSL Support Feb 10, 2025
@inbelic inbelic moved this from Needs Review to Planning in HLSL Support Feb 11, 2025
@damyanp damyanp moved this from Planning to Active in HLSL Support Feb 11, 2025
@damyanp damyanp moved this from Active to Needs Review in HLSL Support Feb 11, 2025
This was referenced Mar 5, 2025
Open
Open
@inbelic inbelic moved this from Needs Review to Active in HLSL Support Mar 25, 2025
@inbelic inbelic moved this from Active to Needs Review in HLSL Support Mar 27, 2025
@inbelic inbelic mentioned this issue Mar 31, 2025
Merged
inbelic added a commit that referenced this issue Mar 31, 2025
@inbelic
[HLSL][RootSignature] Implement parsing of a DescriptorTable with emp…
e4b9486 
…ty clauses (#133302)

- defines the Parser class and an initial set of helper methods to
support consuming tokens. functionality is demonstrated through a simple
empty descriptor table test case
- defines an initial in-memory representation of a DescriptorTable
- implements a test harness that will be used to validate the correct
diagnostics are generated. it will construct a dummy pre-processor with
diagnostics consumer to do so

Implements the first part of
#126569
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this issue Mar 31, 2025
@inbelic @github-actions
Automerge: [HLSL][RootSignature] Implement parsing of a DescriptorTab…
ca29d06 
…le with empty clauses (#133302)

- defines the Parser class and an initial set of helper methods to
support consuming tokens. functionality is demonstrated through a simple
empty descriptor table test case
- defines an initial in-memory representation of a DescriptorTable
- implements a test harness that will be used to validate the correct
diagnostics are generated. it will construct a dummy pre-processor with
diagnostics consumer to do so

Implements the first part of
llvm/llvm-project#126569
inbelic added a commit to inbelic/llvm-project that referenced this issue Mar 31, 2025
@inbelic
[HLSL][RootSignature] Implement parsing of a DescriptorTable with emp…
f3514ce 
…ty clauses (llvm#133302)

- defines the Parser class and an initial set of helper methods to
support consuming tokens. functionality is demonstrated through a simple
empty descriptor table test case
- defines an initial in-memory representation of a DescriptorTable
- implements a test harness that will be used to validate the correct
diagnostics are generated. it will construct a dummy pre-processor with
diagnostics consumer to do so

Implements the first part of
llvm#126569
@inbelic inbelic mentioned this issue Mar 31, 2025
Open
inbelic added a commit to inbelic/llvm-project that referenced this issue Apr 1, 2025
@inbelic
[HLSL][RootSignature] Implement parsing of a DescriptorTable with emp…
4c0cf07 
…ty clauses (llvm#133302)

- defines the Parser class and an initial set of helper methods to
support consuming tokens. functionality is demonstrated through a simple
empty descriptor table test case
- defines an initial in-memory representation of a DescriptorTable
- implements a test harness that will be used to validate the correct
diagnostics are generated. it will construct a dummy pre-processor with
diagnostics consumer to do so

Implements the first part of
llvm#126569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inbelic inbelic

Labels
HLSL HLSL Language Support
Projects
HLSL Support
Status: Needs Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL][RootSignature] Implement Parsing of Descriptor Tables inbelic/llvm-project
1 participant
@inbelic