Skip to content

[HLSL] Root Signature semantic analysis - Bounded Parameter checks #129940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 tasks
inbelic opened this issue Mar 5, 2025 · 0 comments
Open
7 tasks

[HLSL] Root Signature semantic analysis - Bounded Parameter checks #129940

inbelic opened this issue Mar 5, 2025 · 0 comments
Assignees
Labels
HLSL HLSL Language Support

Comments

@inbelic
Copy link
Contributor

inbelic commented Mar 5, 2025

This issue handles the additional semantic analysis of the parsed HLSLRootSignature attribute. This includes generating applicable diagnostics.

The relevant validations that this issue must implement are:

  • Ensure valid values of DESCRIPTOR_RANGE_FLAGS for the Sampler descriptor table clause
  • Ensure that listed parameters of StaticSampler are bounded correctly
  • Validate that the space parameter is not in the invalid range of 0xFFFFFFF0 to 0xFFFFFFFF

AC:

  • Update ParseHLSLRootSignature defined in [HLSL] Generate AST for Root Signatures #119011 to implement semantic validation of HLSLRootSignature
  • Update handleHLSLRootSignature to implement semantic validation of HLSLRootSignature in SemaHLSL.cpp
  • Add thorough testing of correct diagnostics into clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp
  • Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in AST/HLSL/RootSignatures-AST.hlsl
@inbelic inbelic added the HLSL HLSL Language Support label Mar 5, 2025
@inbelic inbelic self-assigned this Mar 5, 2025
@inbelic inbelic moved this to Planning in HLSL Support Mar 5, 2025
@damyanp damyanp moved this from Planning to Ready in HLSL Support Mar 13, 2025
@inbelic inbelic moved this from Ready to Active in HLSL Support Apr 7, 2025
@inbelic inbelic moved this from Active to Ready in HLSL Support Apr 7, 2025
@inbelic inbelic moved this from Ready to Active in HLSL Support Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLSL HLSL Language Support
Projects
Status: Active
Development

No branches or pull requests

1 participant