[clang-tidy] bugprone-assert-side-effect cannot ignore literal operators

[l0rinc]

While preparing Bitcoin Core PR #36030, we found that bugprone-assert-side-effect reports assert(ret > 0s); with CheckFunctionCalls: true.

IgnoredFunctions cannot suppress this pure chrono literal operator, even with .*, because AssertSideEffectCheck.cpp only applies IgnoredFunctionsMatcher to identifier names. Literal operators have operator names.

Removing this restriction would allow qualified regexes to ignore literal operators while preserving the default diagnostic. The restriction remains on LLVM main.

[llvmorg-github-actions]

@llvm/issue-subscribers-clang-tidy

Author: l0rinc (l0rinc)

Details

While preparing [Bitcoin Core PR #36030](https://github.com/bitcoin/bitcoin/pull/36030/changes/af199fb0baa52a00c679771386d1c2470abd1810#diff-74feac260a1487011d7e2126bfebad979cd1ce83114f67b757511d9f3eb58b86), we found that `bugprone-assert-side-effect` reports `assert(ret > 0s);` with `CheckFunctionCalls: true`.

IgnoredFunctions cannot suppress this pure chrono literal operator, even with .*, because AssertSideEffectCheck.cpp only applies IgnoredFunctionsMatcher to identifier names. Literal operators have operator names.

Removing this restriction would allow qualified regexes to ignore literal operators while preserving the default diagnostic. The restriction remains on LLVM main.

[vbvictor]

https://godbolt.org/z/j1v97KsGv