Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick libc++ sized deallocation fix #72255

Closed
ilya-biryukov opened this issue Nov 14, 2023 · 5 comments · Fixed by llvm/llvm-project-release-prs#777
Closed

Cherry-pick libc++ sized deallocation fix #72255

ilya-biryukov opened this issue Nov 14, 2023 · 5 comments · Fixed by llvm/llvm-project-release-prs#777
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Milestone
LLVM 17.0.X Release

Comments

@ilya-biryukov
Copy link
Contributor

This fixes the use of make_shared for arrays (C++20) with -fsized-deallocation. This should be relatively common for those who use C++20.

/cherrypick f722db0
@ilya-biryukov ilya-biryukov added this to the LLVM 17.0.X Release milestone Nov 14, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Nov 14, 2023
@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 14, 2023
@ilya-biryukov ilya-biryukov mentioned this issue Nov 14, 2023
Merged
@ilya-biryukov
Copy link
Contributor Author

/cherry-pick f722db0

@ilya-biryukov
Copy link
Contributor Author

(I hope I am doing it right, it is my first time using this automation)

@llvmbot
Copy link
Member

llvmbot commented Nov 15, 2023

/branch llvm/llvm-project-release-prs/issue72255

@llvmbot llvmbot mentioned this issue Nov 15, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Nov 15, 2023

/pull-request llvm/llvm-project-release-prs#777

@ldionne
Copy link
Member

ldionne commented Nov 15, 2023

Approved for cherry-picking.

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Nov 20, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#72255 llvm/llvm-project-release-prs
4 participants
@ldionne @ilya-biryukov @EugeneZelenko @llvmbot