Removes the influx ping as the services starts up too slowly

Author: lmas

collector/startup_test.go

@@ -15,8 +15,6 @@ import (
 var errNotImplemented = fmt.Errorf("method not implemented")
 
 type mockInflux struct {
-	pingErr bool
-	pingRun bool
 	closeCh chan bool
 }
 
@@ -34,12 +32,6 @@ func (i *mockInflux) Health(ctx context.Context) (*domain.HealthCheck, error) {
 	return nil, errNotImplemented
 }
 func (i *mockInflux) Ping(ctx context.Context) (bool, error) {
-	switch {
-	case i.pingErr:
-		return false, errNotImplemented
-	case i.pingRun:
-		return false, nil
-	}
 	return true, nil
 }
 func (i *mockInflux) Close() {
@@ -101,20 +93,6 @@ func TestStartup(t *testing.T) {
 	}
 	ua.CollectionPeriod = goodPeriod
 
-	// Bad case: error while pinging influxdb server
-	ua.influx = &mockInflux{pingErr: true}
-	err = ua.startup()
-	if err == nil {
-		t.Fatalf("Expected error, got nil")
-	}
-
-	// Bad case: influxdb not running when pinging
-	ua.influx = &mockInflux{pingRun: true}
-	err = ua.startup()
-	if err == nil {
-		t.Fatalf("Expected error, got nil")
-	}
-
 	// Good case: startup() enters loop and can be shut down again
 	c := make(chan bool)
 	ua.influx = &mockInflux{closeCh: c}

collector/unitasset.go

@@ -164,14 +164,6 @@ func (ua *unitAsset) startup() (err error) {
 		return errTooShortPeriod
 	}
 
-	// Make sure we can contact the influxdb server, before trying to do any thing else
-	running, err := ua.influx.Ping(ua.Owner.Ctx)
-	if err != nil {
-		return fmt.Errorf("ping influxdb: %w", err)
-	} else if !running {
-		return fmt.Errorf("influxdb not running")
-	}
-
 	for {
 		select {
 		// Wait for a shutdown signal