Don't accept inbound connection establishments more than peering_degree

[youngjoon-lee]

If a node already has the max_peering_degree number of connections, the node should reject additional inbound connection establishments to save bandwidth.
This has been discussed in the comment and added in the specification at 2024-12-10.

[danielSanchezQ]

If a node already has the peering_degree number of healthy connections, the node should reject additional inbound connection establishments to save bandwidth. This hasn't been specified in the specification, but recently discussed in the comment. Here, we shouldn't use the max_peering_degree parameter, which is for limiting additional "outbound" connection establishments to replace malicious/unhealthy connections, not for limiting inbound connection establishments.

I thought connections were used for both sending and receiving meaning that blendnodes would have a total of max_peering_degree connections. This kinda makes sense, if a peer is missbehaving then we need to remove both incoming and outgoing (streams, as the connection should be the same?).

[youngjoon-lee]

I thought connections were used for both sending and receiving meaning that blendnodes would have a total of max_peering_degree connections. This kinda makes sense, if a peer is missbehaving then we need to remove both incoming and outgoing (streams, as the connection should be the same?).

Exactly. I developed the discussion with Marcin and update the specification. Accordingly, I updated the issue description above. Yes. All connections are bidirectional. Each node must have max_peering_degree connections at most.