Expand linting to catch fdescribe in tests, other issues.

Author: Will Scullin

package-lock.json

@@ -14,9 +14,9 @@
   "scripts": {
     "build": "npm run clean && npm run build_utils && webpack",
     "build_utils": "tsc --build tsconfig-server.json",
-    "clean": "rm -r lib dist",
-    "lint": "tslint --project tsconfig.json --format stylish 'src/**/*.ts' 'server_utils/*.ts'",
-    "lint-fix": "tslint --fix --project tsconfig.json  --format stylish 'src/**/*.ts' 'server_utils/*.ts'",
+    "clean": "rm -rf lib dist",
+    "lint": "tslint --project tsconfig-lint.json --format stylish",
+    "lint-fix": "tslint --fix --project tsconfig-lint.json  --format stylish",
     "start": "npm run build_utils && webpack-dev-server --config webpack-devserver.config.js --hot --inline --open --color --progress",
     "python": "webpack --config webpack-devserver.config.js && python demo/demo.py",
     "test": "npm run lint && karma start karma.conf.js",
@@ -50,6 +50,7 @@
     "ts-loader": "^5.3.3",
     "tslint": "^5.8.0",
     "tslint-config-standard": "^8.0.0",
+    "tslint-defocus": "^2.0.6",
     "tslint-eslint-rules": "^4.1.1",
     "typescript": "^3.3.3",
     "typescript-tslint-plugin": "0.1.2",

package.json

@@ -66,6 +66,7 @@ function createNonce(len) {
     }
     return text;
 }
+;
 function createSignedUrl(src, user, host, secret, nonce) {
     var jsonTime = JSON.stringify(Math.floor((new Date()).getTime() / 1000));
     var jsonNonce = JSON.stringify(nonce || createNonce(16));

server_utils/auth_utils.js

@@ -35,7 +35,7 @@ const testUser = () => ({
   'permissions': [
     'access_data',
     'see_looks',
-    'see_user_dashboards',
+    'see_user_dashboards'
   ] as LookerUserPermission[],
   'models': ['powered_by', 'thelook'],
   'user_attributes': { 'locale': 'en_US' },
@@ -48,7 +48,7 @@ const testHost = 'test.looker.com'
 const testSecret = 'hunter2'
 const testNonce = 'abc123'
 
-fdescribe('createSignedUrl', () => {
+describe('createSignedUrl', () => {
   beforeEach(() => {
     jasmine.clock().install()
     jasmine.clock().mockDate(new Date(1561486800168))

tests/auth_utils.spec.ts

@@ -25,13 +25,14 @@
 import { LookerEmbedSDK, LookerEmbedDashboard } from '../src/index'
 import { ChattyHost } from '@looker/chatty'
 import mock from 'xhr-mock'
+import { EmbedClient } from '../src/embed'
 
 const testUrl = '/base/tests/test.html'
 
 describe('LookerEmbed', () => {
   let builder
   let el
-  let client
+  let client: any
 
   beforeEach(() => {
     LookerEmbedSDK.init('host.looker.com:9999', '/auth')
@@ -40,7 +41,7 @@ describe('LookerEmbed', () => {
   })
 
   describe('with ID', () => {
-    let fakeDashboardClient
+    let fakeDashboardClient: any
 
     beforeEach(() => {
       mock.setup()
@@ -92,15 +93,15 @@ describe('LookerEmbed', () => {
 
       client.connect()
         .then(done.fail)
-        .catch((error) => {
+        .catch((error: any) => {
           expect(error).toEqual('foo')
           done()
         })
     })
   })
 
   describe('with URL', () => {
-    let fakeDashboardClient
+    let fakeDashboardClient: any
 
     beforeEach(() => {
       fakeDashboardClient = {}
@@ -139,8 +140,8 @@ describe('LookerEmbed', () => {
 
   describe('creating an iframe', () => {
     let fakeDashboardClient
-    let el
-    let iframe
+    let el: HTMLDivElement
+    let iframe: HTMLIFrameElement
 
     beforeEach(() => {
       el = document.createElement('div')
@@ -155,7 +156,7 @@ describe('LookerEmbed', () => {
       builder.withClassName('classy')
       client = builder.build()
       spyOn(window, 'fetch')
-      spyOn(ChattyHost.prototype, 'connect').and.callFake(async function () {
+      spyOn(ChattyHost.prototype, 'connect').and.callFake(async function (this: any) {
         iframe = this.iframe
         return Promise.resolve({})
       })
@@ -170,6 +171,7 @@ describe('LookerEmbed', () => {
         .then(() => {
           expect(iframe.sandbox.toString()).toEqual('allow-scripts')
           expect(iframe.classList.toString()).toEqual('classy')
+          // tslint:disable-next-line:deprecation
           expect(iframe.frameBorder).toEqual('0')
           expect(iframe.src).toMatch(testUrl)
           done()

tests/embed.spec.ts

@@ -24,13 +24,14 @@
 
 import { LookerEmbedDashboard } from '../src/dashboard_client'
 import { EmbedClient } from '../src/embed'
+import { EmbedBuilder } from '../src/embed_builder'
 import { LookerEmbedExplore } from '../src/explore_client'
 import { LookerEmbedSDK } from '../src/index'
 import { LookerEmbedLook } from '../src/look_client'
 
 describe('LookerEmbedBuilder', () => {
-  let builder
-  let el
+  let builder: EmbedBuilder<LookerEmbedDashboard>
+  let el: HTMLDivElement
 
   beforeEach(() => {
     LookerEmbedSDK.init('host.looker.com:9999', '/auth')
@@ -153,7 +154,7 @@ describe('LookerEmbedBuilder', () => {
     })
 
     it('should add url parameters', () => {
-      builder.withParams({ alpha: 1, beta: 2 })
+      builder.withParams({ alpha: '1', beta: '2' })
       expect(builder.embedUrl).toMatch('alpha=1&beta=2')
     })
 

tests/embed_builder.spec.ts

@@ -0,0 +1,26 @@
+{
+  "compilerOptions": {
+
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "noEmit": true,
+    "noImplicitReturns": true,
+    "strict": true,
+    "target": "ES5",
+    "lib": ["es6", "es2017.object"],
+    "plugins": [
+      {
+        "name": "typescript-tslint-plugin",
+        "alwaysShowRuleFailuresAsWarnings": true
+      }
+    ]
+  },
+  "exclude": [
+    "node_modules"
+  ],
+  "include": [
+    "src",
+    "server_utils",
+    "tests"
+  ]
+}

tsconfig-lint.json

@@ -1,10 +1,12 @@
 {
   "defaultSeverity": "error",
   "extends": [
+    "tslint-defocus",
     "tslint-config-standard"
   ],
   "jsRules": {},
   "rules": {
+    "defocus": true,
     "no-namespace": [true, "allow-declarations"],
     "prefer-const": [true, {"destructuring": "all"}],
     "no-reference": true,