Skip to content
This repository was archived by the owner on Jun 12, 2025. It is now read-only.

Commit 929d3ac

Browse files
committed
Update Windows CI to windows-2025
windows-2019 will be fully retired by the end of June, and 2025 is the latest version. This means that Windows build artifacts will be built using MSVC 2022, not MSVC 2019. They should be ABI-compatible across this change, since they expose no third-party types and Microsoft say that their compiler and standard library didn't break ABI between 2019 and 2022, but a newer version of the redistributable might be needed.
1 parent ddc40b7 commit 929d3ac

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ env:
1212

1313
jobs:
1414
windows:
15-
runs-on: windows-2019
15+
runs-on: windows-2025
1616

1717
strategy:
1818
matrix:
@@ -55,7 +55,7 @@ jobs:
5555
run: |
5656
mkdir build
5757
cd build
58-
cmake .. -G "Visual Studio 16 2019" -A ${{ matrix.platform }} -DCPACK_PACKAGE_VERSION="${{ steps.get-version.outputs.version }}-python${{ matrix.python-version }}"
58+
cmake .. -G "Visual Studio 17 2022" -A ${{ matrix.platform }} -DCPACK_PACKAGE_VERSION="${{ steps.get-version.outputs.version }}-python${{ matrix.python-version }}"
5959
cmake --build . --config ${{ env.MSVC_CONFIG }}
6060
6161
- name: Run tests

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
tag_name: ${{ steps.get-git-tag.outputs.name }}
2828
release_name: libloot-python v${{ steps.get-git-tag.outputs.name }}
2929
body: |
30-
Requires Windows 7 or later and the [MSVC 2019 x86 redistributable](https://aka.ms/vs/16/release/vc_redist.x86.exe), and [7-Zip](http://www.7-zip.org/) to extract the archive.
30+
Requires Windows 7 or later and the [MSVC 2022 x86 redistributable](https://aka.ms/vs/17/release/vc_redist.x86.exe), and [7-Zip](http://www.7-zip.org/) to extract the archive.
3131
3232
windows:
33-
runs-on: windows-2019
33+
runs-on: windows-2025
3434
needs: create_release
3535

3636
strategy:
@@ -61,7 +61,7 @@ jobs:
6161
run: |
6262
mkdir build
6363
cd build
64-
cmake .. -G "Visual Studio 16 2019" -A ${{ matrix.platform }} -DCPACK_PACKAGE_VERSION="${{ steps.get-version.outputs.version }}-python${{ matrix.python-version }}"
64+
cmake .. -G "Visual Studio 17 2022" -A ${{ matrix.platform }} -DCPACK_PACKAGE_VERSION="${{ steps.get-version.outputs.version }}-python${{ matrix.python-version }}"
6565
cmake --build . --config ${{ env.MSVC_CONFIG }}
6666
6767
- name: Build archive

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ libloot-python
33

44
This archive contains a build of the libloot-python wrapper module and its corresponding 32-bit Windows build of libloot.
55

6-
The DLL requires the [MSVC 2019 x86 redistributable](https://aka.ms/vs/16/release/vc_redist.x86.exe)
6+
The DLL requires the [MSVC 2022 x86 redistributable](https://aka.ms/vs/17/release/vc_redist.x86.exe)
77
to be installed.
88

99
See the [online documentation](http://loot-api-python.readthedocs.org/) for more information.

docs/usage.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ Build archives contain two binaries:
1010
* ``loot.*.pyd`` is the Python wrapper
1111
* ``loot.dll`` is the C++ library DLL that the Python wrapper was built against.
1212

13-
The C++ DLL requires the `Visual C++ 2019 Redistributable (x86)`_
13+
The C++ DLL requires the `Visual C++ 2022 Redistributable (x86)`_
1414
to be installed.
1515

1616
To use the wrapper, copy both files to wherever you want to import them from
1717
(they must be in the same folder), and you're done!
1818

19-
.. _Visual C++ 2019 Redistributable (x86): https://aka.ms/vs/16/release/vc_redist.x86.exe
19+
.. _Visual C++ 2022 Redistributable (x86): https://aka.ms/vs/17/release/vc_redist.x86.exe
2020

2121
Using the wrapper
2222
=================

0 commit comments

Comments
 (0)