Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Localization in other languages #176

Closed
amir16yp opened this issue Jan 5, 2025 · 2 comments
Closed

[FEATURE] Localization in other languages #176

amir16yp opened this issue Jan 5, 2025 · 2 comments
Labels
feature Feature request

Comments

@amir16yp
Copy link
Contributor

amir16yp commented Jan 5, 2025

Is your feature request related to a problem? Please describe.
I think this program might benefit from localization into different languages

Describe the solution you'd like
Instead of hardcoding english, create a localization json or similar data structure, and allow users to contribute their own translations with key pair values

Additional context
This program is really popular among russian and spanish speakers. This video about arnis in russian has 40k views. This one in spanish has 200k. I also saw one of the forks being simply a translation into chinese.

@amir16yp amir16yp added the feature Feature request label Jan 5, 2025
@louis-e
Copy link
Owner

louis-e commented Jan 5, 2025

Woah, didn't know about the Spanish >200k video until now - really cool!
Yes, I really like that idea! I think English, Spanish, Russian and German seems to be most asked for as of now.

@louis-e
Copy link
Owner

louis-e commented Jan 6, 2025

I'll close this issue for now - feature is implemented and already merged into main!
Just want to get a bit more feedback from native speakers until I include it in a release. I'm using #193 as a feedback thread for this. Thanks a lot Amir :)

@louis-e louis-e closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants