Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fio-plot only allows specific metrics to be plotted - users can't select the metrics they want to plot #69

Open
louwrentius opened this issue Feb 6, 2022 · 6 comments
Assignees

Comments

@louwrentius
Copy link
Owner

louwrentius commented Feb 6, 2022

Fio-plot can deal with:

  • Bandwidth
  • IOPs
  • Latency
  • Histogram

If you want to plot any other data found inside the JSON file, that's currently not possible.

Why is this?

  • Fio-plot is maybe my second Python application ever written and also by far the largest one
  • Only the above data/fields are statically mapped from the JSON file into a flat dictionary for further graphing
  • The graphs are all hard-coded and are only aware of (some of) the above metrics.

The desired state would be that the user selects the metrics they want from the JSON to be graphed and fio-plot just 'deals with it'.

There are a few challenges:

  1. This does mean that the application should be able to understand the unit type of the metric.
  2. Some metrics consists of lists or internal dictionaries that needs to be understood/parsed.

Please note that I'm not a professional developer by any means and this would be a significant undertaking. It would probably mean very significant rework of a lot of components. It must be understood that there is therefore no timeline for this improvement.

@louwrentius louwrentius self-assigned this Feb 6, 2022
@louwrentius
Copy link
Owner Author

This issue is related to issue #67 where this limitation is mentioned.

@louwrentius
Copy link
Owner Author

feedback or ideas on how to deal with this are much appreciated

@jsrolon
Copy link
Contributor

jsrolon commented Feb 20, 2022

I believe there should be a significant investment in changing the way graphs are specified. IMO the current CLI-based way to interact with fio-plot is cumbersome as it is, and it would become even more unwieldy if users were to be able to specify their own graphs. Should #34 be reconsidered for both bench_fio and fio_plot?

@louwrentius
Copy link
Owner Author

@jsrolon yes I can see that. I would not remove the CLI option (personal preference) but a configuration file makes sense. In that case I think the same format as FIO uses (ini) is good enough, but other ideas are welcome.

@louwrentius
Copy link
Owner Author

louwrentius commented Jul 18, 2022

I believe there should be a significant investment in changing the way graphs are specified. IMO the current CLI-based way to interact with fio-plot is cumbersome as it is, and it would become even more unwieldy if users were to be able to specify their own graphs. Should #34 be reconsidered for both bench_fio and fio_plot?

@jsrolon

In the latest release I've added support for INI configuration file for bench-fio only. I hope to re-use some of this for fio-plot at some point. So #34 is not addressed yet but it's one step closer.

@louwrentius
Copy link
Owner Author

@jsrolon In the latest release I've also added support for INI configuration for fio-plot so #34 is now addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants