surface hand batch child deletes in optimistic prune plan#389
Open
lovasoa wants to merge 1 commit into
Open
Conversation
optimisticPrunePlanForAuthoritativeMessage only handled top-level DELETE/CLEAR. Hand selection deletes are sent as a BATCH of child delete messages, so peer deletes left stale optimistic state. Now inspect batch _children: collect child DELETE ids and treat a child CLEAR as reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surface hand batch child deletes in optimistic prune plan
optimisticPrunePlanForAuthoritativeMessage()only invalidated optimistic state for top-levelDELETE/CLEAR. ButgetMutationType()returnsBATCHwhenever_childrenis present, so child deletes inside hand-tool selection batches (deleteSelection()) were never surfaced. A peer deleting an item via hand selection while this client held pending optimistic writes for it would leave stale state that could later resurrect.This adds a
BATCHbranch that walks_children, collecting every childDELETEid intoinvalidatedIdsand treating a childCLEARasreset. Top-level handling is unchanged.Tested:
The 2 new tests cover a hand batch with child deletes (mixed with an UPDATE) and a child clear.
npm run lintandnpm run typecheckare clean.