Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store conversations locally in db #394

Open
FelberMartin opened this issue Feb 6, 2025 · 0 comments
Open

Store conversations locally in db #394

FelberMartin opened this issue Feb 6, 2025 · 0 comments
Labels
bug Something isn't working improvement Minor improvements, no new functionality

Comments

@FelberMartin
Copy link
Collaborator

FelberMartin commented Feb 6, 2025

Description

While working on #375, I noticed that conversations are not stored locally in the db. This leads to problems, as we listen for websocket updates in the conversationOverviewModel, and update the unread counter when new post creations arrive. However these counter updates are only local to the conversationOverview and we can not consume them in the ConversationViewmodel. There we would need the updates to properly show the unread indicator.

Additionally, Julian discovered this bug that may also be mitigated by storing the conversations locally.

Next steps

  • Create db entities for the different conversation types
  • Create a ConversationRepository that handles the snychronization of the db
  • Confirm that both mentioned bugs are resolved
  • Remove the feature toggle for the unreadIndicator
@FelberMartin FelberMartin self-assigned this Feb 6, 2025
@FelberMartin FelberMartin added bug Something isn't working improvement Minor improvements, no new functionality labels Feb 6, 2025
@FelberMartin FelberMartin removed their assignment Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Minor improvements, no new functionality
Projects
None yet
Development

No branches or pull requests

1 participant