Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add FAQ categories #418

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature: Add FAQ categories #418

wants to merge 8 commits into from
+364 −43

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

Categories can be added to FAQs to easily group them and allow users to quickly find what they are looking for.

This PR closes #399

Changes

  • Display FAQ categories in both the Overview and Details screen
  • Allow users to filter FAQs by category
  • Added UI tests

Steps for testing

Go to a course with FAQs (eg TS2 > Test Course Martin Felber)

  • Check that the FAQ categories are displayed in both the Overview and details screen
  • Check that filtering by category works as expected

Screenshots

image

@FelberMartin FelberMartin self-assigned this Feb 14, 2025
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Feb 14, 2025
eylulnc
eylulnc requested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its looking really nice and works a sexpected.

One suggestion on my side is

Screenshot 2025-02-15 at 16 41 03

This is looking cut out a lot.
Maybe the categories and read more should not display in the same line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eylulnc eylulnc eylulnc requested changes

@julian-wls julian-wls Awaiting requested review from julian-wls

Requested changes must be addressed to merge this pull request.

Assignees

@FelberMartin FelberMartin

Labels
ready for review This PR can be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ: Add categories
2 participants
@FelberMartin @eylulnc