🔨 refactor js handler to delete old comments, fix io redirection

Author: ltetzlaff

check_no_api_breakages.sh

@@ -36,7 +36,7 @@ function build_and_do() {
 
     (
     cd "$repodir"
-    git checkout -q "$tag"
+    git -c advice.detachedHead=false checkout -q "$tag"
     swift build
     while read -r module; do
         swift api-digester -sdk "$sdk" -dump-sdk -module "$module" \
@@ -71,13 +71,11 @@ fi
 
 hash jq 2> /dev/null || { echo >&2 "ERROR: jq must be installed"; exit 1; }
 tmpdir=$(mktemp -d /tmp/.check-api_XXXXXX)
-repo_url=$1
+repodir=$1
 new_tag=$2
 shift 2
 
-repodir="$tmpdir/repo"
-git clone -q "$repo_url" "$repodir"
-git -C "$repodir" fetch -q origin '+refs/pull/*:refs/remotes/origin/pr/*'
+git -C "$repodir" fetch -q --prune
 errors=0
 
 for old_tag in "$@"; do
@@ -103,9 +101,12 @@ for old_tag in "$@"; do
             > "$report" 2>&1
 
         if ! shasum "$report" | grep -q cefc4ee5bb7bcdb7cb5a7747efa178dab3c794d5; then
+            echo ERROR
             echo >&2 "🔀 Public API change in $f"
             cat >&2 "$report"
             errors=$(( errors + 1 ))
+        else
+            echo OK
         fi
     done
     rm -rf "$tmpdir/api-new" "$tmpdir/api-old"

entrypoint.sh

@@ -1,8 +1,7 @@
 #!/bin/bash
 
 # Run the breakage checker script and hand the API Diff report to the user
-REPORT_PATH=/report.txt
-OLD_REF=$GITHUB_BASE_REF
-echo "Comparing $GITHUB_SHA with $OLD_REF and writing to $REPORT_PATH"
-/check_no_api_breakages.sh $GITHUB_WORKSPACE $GITHUB_SHA $OLD_REF 2>$REPORT_PATH
+REPORT_PATH=/breakage-report.txt
+echo "Comparing $GITHUB_HEAD_REF with $GITHUB_BASE_REF and writing to $REPORT_PATH"
+/check_no_api_breakages.sh $GITHUB_WORKSPACE $GITHUB_HEAD_REF $GITHUB_BASE_REF 2>$REPORT_PATH
 node /src/entrypoint.js $REPORT_PATH

src/entrypoint.js

@@ -1,9 +1,13 @@
 const { readFile } = require("fs").promises
 const { Toolkit } = require("actions-toolkit")
+const getComments = require("./get-comments")
+
 const tools = new Toolkit()
 const argv = process.argv.slice(2)
 // const arguments = tools.arguments
 
+const me = "github-actions[bot]"
+
 const [ reportFilePath ] = argv
 const { event, payload, sha } = tools.context
 
@@ -23,20 +27,32 @@ async function run() {
     report = error
   }
 
-  const octokit = tools.github
+  const {issues} = tools.github
 
   // add comment on PR
   const { owner, repo } = tools.context.repo
+  const params = { owner, repo }
 
   const body = `## API Breakage Report\n${report}`
 
+  const commentParams = {
+    ...params,
+    issue_number: pr
+      ? pr.number
+      : tools.context.issue.number
+  }
+
   try {
-    await octokit.issues.createComment({
-      owner,
-      repo,
-      issue_number: pr
-        ? pr.number
-        : tools.context.issue.number,
+    const myComments = await getComments(issues, commentParams, me)
+
+    // Delete old comments by this action
+    await Promise.all(myComments.map(async ({ id }) => issues.deleteComment({
+      ...commentParams,
+      comment_id: id
+    })))
+
+    await issues.createComment({
+      ...commentParams,
       body
     })
 

src/get-comments.js

@@ -0,0 +1,25 @@
+const PER_PAGE = 100
+
+module.exports = async function getComments(issues, params, ofUser) {
+  const myComments = []
+
+  let page = 0
+  while (true) {
+    const nextComments = (await issues.listComments({
+      ...params,
+      per_page: PER_PAGE,
+      page
+    })).data
+
+    if (ofUser === undefined) {
+      myComments.push(...nextComments)
+    } else {
+      myComments.push(...nextComments.filter(c => c.user.login === ofUser))
+    }
+
+    page++
+    if (nextComments.length < PER_PAGE) break
+  }
+
+  return myComments
+}