Skip to content

Commit 6b837f2

Browse files
committed
Use ubuntu-latest on GHA when possible
We need ubuntu-20.04 for coverage analysis (clang after 10 doesn't seem to properly interact with gcov version used for codecov) and for releases (to produce binaries targeting earlier glibc). However, we still should be verifying that Luau builds on latest, because newer toolchains have stricter standard library headers and/or warnings; without this we're at risk of constantly regressing the build for packaging or external applications. Note that release.yml can probably just be deleted but for now we simply adjust it.
1 parent 1cda830 commit 6b837f2

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
unix:
2121
strategy:
2222
matrix:
23-
os: [{name: ubuntu, version: ubuntu-20.04}, {name: macos, version: macos-latest}]
23+
os: [{name: ubuntu, version: ubuntu-latest}, {name: macos, version: macos-latest}]
2424
name: ${{matrix.os.name}}
2525
runs-on: ${{matrix.os.version}}
2626
steps:
@@ -83,7 +83,7 @@ jobs:
8383
Debug/luau-compile tests/conformance/assert.lua
8484
8585
coverage:
86-
runs-on: ubuntu-20.04
86+
runs-on: ubuntu-20.04 # needed for clang++-10 to avoid gcov compatibility issues
8787
steps:
8888
- uses: actions/checkout@v2
8989
- name: install
@@ -99,7 +99,7 @@ jobs:
9999
token: ${{ secrets.CODECOV_TOKEN }}
100100

101101
web:
102-
runs-on: ubuntu-20.04
102+
runs-on: ubuntu-latest
103103
steps:
104104
- uses: actions/checkout@v1
105105
- uses: actions/checkout@v2

.github/workflows/new-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ permissions:
1212

1313
jobs:
1414
create-release:
15-
runs-on: ubuntu-20.04
15+
runs-on: ubuntu-latest
1616
outputs:
1717
upload_url: ${{ steps.create_release.outputs.upload_url }}
1818
steps:
@@ -29,7 +29,7 @@ jobs:
2929
build:
3030
needs: ["create-release"]
3131
strategy:
32-
matrix:
32+
matrix: # using ubuntu-20.04 to build a Linux binary targeting older glibc to improve compatibility
3333
os: [{name: ubuntu, version: ubuntu-20.04}, {name: macos, version: macos-latest}, {name: windows, version: windows-latest}]
3434
name: ${{matrix.os.name}}
3535
runs-on: ${{matrix.os.version}}
@@ -56,7 +56,7 @@ jobs:
5656

5757
web:
5858
needs: ["create-release"]
59-
runs-on: ubuntu-20.04
59+
runs-on: ubuntu-latest
6060
steps:
6161
- uses: actions/checkout@v1
6262
- uses: actions/checkout@v2

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313
jobs:
1414
build:
1515
strategy:
16-
matrix:
16+
matrix: # using ubuntu-20.04 to build a Linux binary targeting older glibc to improve compatibility
1717
os: [{name: ubuntu, version: ubuntu-20.04}, {name: macos, version: macos-latest}, {name: windows, version: windows-latest}]
1818
name: ${{matrix.os.name}}
1919
runs-on: ${{matrix.os.version}}
@@ -35,7 +35,7 @@ jobs:
3535
path: Release\luau*.exe
3636

3737
web:
38-
runs-on: ubuntu-20.04
38+
runs-on: ubuntu-latest
3939
steps:
4040
- uses: actions/checkout@v1
4141
- uses: actions/checkout@v2

0 commit comments

Comments
 (0)