Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize the irfgen folder #652

Open
lucabaldini opened this issue Oct 14, 2022 · 0 comments
Open

Sanitize the irfgen folder #652

lucabaldini opened this issue Oct 14, 2022 · 0 comments
Assignees

Comments

@lucabaldini
Copy link
Owner

While splitting the code for the generation of the response files out of the older ixpeobssim private repository I did notice that the original cut between the modules that were released and those that were not was suboptimal.

More specifically, in order to decouple things in a sensible way, I ended up adding to the new (private) ixpeirfgen repository the following files

ixpeirfgen/auxiliary.py
ixpeirfgen/base.py
ixpeirfgen/data/du/
ixpeirfgen/du.py
ixpeirfgen/gpd.py
ixpeirfgen/mma.py

Bottomline: we currently have significant code duplication between ixpeobssim and ixpeirfgen, that would be good to reduce in the future.

I am under the impression that some of the aforementioned files (e.g., base.py) could be just removed from ixpeobssim, and others could be stripped down to the bare minimum.

@lucabaldini lucabaldini self-assigned this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant