-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox spuriously fallbacks to it's own notifications #8
Comments
Or sorry, not a crash. But it makes firefox think it crashed because it sends an error back to it over DBus (my educated guess). So firefox starts using it's own notification popups again. |
Interesting. The closing after the timeout is implemented as a filter over the list of notifications, so if a notification was already closed/removed before, it should be a no-op. But we currently don't send the NotificationClosed signal; maybe that causes issues in some cases. On the other hand, when notifications simply time out, it seems to work even without the signal. It's late here, I will try to reproduce this tomorrow. |
I cannot reproduce this by closing notifications manually. However, it seems that sometimes Firefox notices when I restart end to apply changes and then falls back to its own notifications. Restarting Firefox while end is running fixes this. Is this maybe what happened in your case as well? |
Very odd. Now I can't reproduce it either. I will keep this open for bit while I observe to see when firefox breaks. |
It's still definitely happening, I just can't say why. It does happen even when I'm not messing around with end. And end doesn't even print anything when firefox stops liking it. I'm stumped |
Maybe this is related to all the missing signals we're not sending. |
I have it so when I click on my notification in eww, it'll call
end close <id>
. But when the timeout for the notification is up and end tries to close it, it fails and crashes because the notification is already closedThe text was updated successfully, but these errors were encountered: