Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest frame trimming is over deleting frames #28

Open
lucamuscat opened this issue Jan 12, 2025 · 0 comments
Open

Pytest frame trimming is over deleting frames #28

lucamuscat opened this issue Jan 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@lucamuscat
Copy link
Owner

In order to prettify the final output, Perfsephone indiscriminately ignores all pytest related frames, assuming that pytest related frames will only show up outside of the test being profiled itself.

It would be nice if the trimmed pytest frames are actually those frames outside of the test, and not pytest related frames inside the test. There are definitely code bases (namely, this one), which uses pytest itself INSIDE their own tests for whatever reason.

@lucamuscat lucamuscat added the bug Something isn't working label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant