perf: reallocate buffers for fetching messages

Author: celestix

internal/store/message.go

@@ -109,36 +109,19 @@ func (ms *MessageStore) GetMessages(jid types.JID) []Message {
 	return ml
 }
 
-// GetMessagesPaged returns a page of messages for a chat
-// beforeTimestamp: only return messages before this timestamp (0 = latest)
-// limit: max number of messages to return
-// Returns messages in chronological order (oldest first within the page)
-func (ms *MessageStore) GetMessagesPaged(jid types.JID, beforeTimestamp int64, limit int) []Message {
-	var rows *sql.Rows
-	var err error
-
-	if beforeTimestamp == 0 {
-		// Get latest messages using the optimized query
-		rows, err = ms.db.Query(query.SelectLatestMessagesByChat, jid.String(), limit)
-	} else {
-		// Get messages before timestamp using the optimized query
-		rows, err = ms.db.Query(query.SelectMessagesByChatBeforeTimestamp, jid.String(), beforeTimestamp, limit)
-	}
-
-	if err != nil {
-		return []Message{}
-	}
-	defer rows.Close()
+func getMessageArrayFromRows(rows *sql.Rows) []Message {
+	var (
+		messages []Message
+		chat     string
+		msgID    string
+		ts       int64
+		minf     []byte
+		raw      []byte
+	)
 
-	var messages []Message
 	for rows.Next() {
-		var (
-			chat  string
-			msgID string
-			ts    int64
-			minf  []byte
-			raw   []byte
-		)
+		minf = minf[:0]
+		raw = raw[:0]
 
 		if err := rows.Scan(&chat, &msgID, &ts, &minf, &raw); err != nil {
 			continue
@@ -150,7 +133,7 @@ func (ms *MessageStore) GetMessagesPaged(jid types.JID, beforeTimestamp int64, l
 		}
 
 		var waMsg *waE2E.Message
-		waMsg, err = unmarshalMessageContent(raw)
+		waMsg, err := unmarshalMessageContent(raw)
 		if err != nil {
 			continue
 		}
@@ -159,58 +142,34 @@ func (ms *MessageStore) GetMessagesPaged(jid types.JID, beforeTimestamp int64, l
 			Info:    messageInfo,
 			Content: waMsg,
 		})
-		ms.mCache.Set(msgID, 1)
 	}
 
 	return messages
 }
 
-// loadAndCacheAllMessages loads all messages for a chat from DB and caches them
-func (ms *MessageStore) loadAndCacheAllMessages(jid types.JID) []Message {
-	rows, err := ms.db.Query(query.SelectMessagesByChat, jid.String())
-	if err != nil {
-		return []Message{}
-	}
-	defer rows.Close()
-
-	var messages []Message
-	for rows.Next() {
-		var (
-			chat  string
-			msgID string
-			ts    int64
-			minf  []byte
-			raw   []byte
-		)
-
-		if err := rows.Scan(&chat, &msgID, &ts, &minf, &raw); err != nil {
-			continue
-		}
-
-		var messageInfo types.MessageInfo
-		if err := gobDecode(minf, &messageInfo); err != nil {
-			continue
-		}
-
-		var waMsg *waE2E.Message
-		waMsg, err = unmarshalMessageContent(raw)
-		if err != nil {
-			continue
-		}
+// GetMessagesPaged returns a page of messages for a chat
+// beforeTimestamp: only return messages before this timestamp (0 = latest)
+// limit: max number of messages to return
+// Returns messages in chronological order (oldest first within the page)
+func (ms *MessageStore) GetMessagesPaged(jid types.JID, beforeTimestamp int64, limit int) []Message {
+	var rows *sql.Rows
+	var err error
 
-		messages = append(messages, Message{
-			Info:    messageInfo,
-			Content: waMsg,
-		})
-		ms.mCache.Set(msgID, 1)
+	if beforeTimestamp == 0 {
+		// Get latest messages using the optimized query
+		rows, err = ms.db.Query(query.SelectLatestMessagesByChat, jid.String(), limit)
+	} else {
+		// Get messages before timestamp using the optimized query
+		rows, err = ms.db.Query(query.SelectMessagesByChatBeforeTimestamp, jid.String(), beforeTimestamp, limit)
 	}
 
-	// Cache the loaded messages
-	if len(messages) > 0 {
-		ms.msgMap.Set(jid.User, messages)
+	if err != nil {
+		return []Message{}
 	}
 
-	return messages
+	defer rows.Close()
+
+	return getMessageArrayFromRows(rows)
 }
 
 // loadMessagesFromDBForChat loads messages for a specific chat from DB
@@ -221,38 +180,7 @@ func (ms *MessageStore) loadMessagesFromDBForChat(jid types.JID) []Message {
 	}
 	defer rows.Close()
 
-	var messages []Message
-	for rows.Next() {
-		var (
-			chat  string
-			msgID string
-			ts    int64
-			minf  []byte
-			raw   []byte
-		)
-
-		if err := rows.Scan(&chat, &msgID, &ts, &minf, &raw); err != nil {
-			continue
-		}
-
-		var messageInfo types.MessageInfo
-		if err := gobDecode(minf, &messageInfo); err != nil {
-			continue
-		}
-
-		var waMsg *waE2E.Message
-		waMsg, err = unmarshalMessageContent(raw)
-		if err != nil {
-			continue
-		}
-
-		messages = append(messages, Message{
-			Info:    messageInfo,
-			Content: waMsg,
-		})
-		ms.mCache.Set(msgID, 1)
-	}
-	return messages
+	return getMessageArrayFromRows(rows)
 }
 
 // GetTotalMessageCount returns the total number of messages in a chat
@@ -294,14 +222,18 @@ func (ms *MessageStore) GetChatList() []ChatMessage {
 	defer rows.Close()
 
 	var chatList []ChatMessage
+
+	var (
+		chat  string
+		msgID string
+		ts    int64
+		minf  []byte
+		raw   []byte
+	)
+
 	for rows.Next() {
-		var (
-			chat  string
-			msgID string
-			ts    int64
-			minf  []byte
-			raw   []byte
-		)
+		minf = minf[:0]
+		raw = raw[:0]
 
 		if err := rows.Scan(&chat, &msgID, &ts, &minf, &raw); err != nil {
 			continue