Fail when artifacts are empty?

[fauno]

Hi! I just had an issue with http-parser. It built correctly but the library was missing because the rake task wasn't copying it into lib/, the gem requires it directly from ext/.

So I had to add --include-shared-dir ext/ to the build, but I think it could be better if gem compiler fails if there aren't artifacts to add to the binary gem.

I can send a PR :)

[luislavena]

Hello @fauno, thank you for submitting this issue.

Bear with me as I'm not familiar with what http-parser does or how, are they leveraging on FFI to load a compiled shared library?

If that is the case, then perhaps a change can be introduced to validate that collected artifacts are > 0, that for sure will catch these gems that say have extensions but they really don't 😊

A PR will be more than welcome, just make sure to cover this scenario in the tests to avoid future me messing it up with some refactoring 😅

I might not have enough time to review and respond promptly for the upcoming weeks, but that doesn't mean I don't appreciate your effort.

Thank you
❤️ ❤️ ❤️

[fauno]

No problem! I solved it already by adding the flag I mentioned to our CI and it's the first time I see this in 2+ years using gem-compiler... You can check it like this: ``` gem fetch --source https://gems.sutty.nl --platform x86_64-linux-musl http-parser tar xOf http-parser-1.2.3-x86_64-linux-musl.gem data.tar.gz | tar ztf - LICENSE README.md Rakefile ext/Rakefile ext/http-parser/http_parser.c ext/http-parser/http_parser.h ext/x86_64-linux/libhttp-parser-ext.so http-parser.gemspec lib/http-parser.rb lib/http-parser/errors.rb lib/http-parser/ext.rb lib/http-parser/parser.rb lib/http-parser/types.rb lib/http-parser/version.rb spec/error_spec.rb spec/instance_spec.rb spec/parser_spec.rb ``` and `lib/http-parser.rb` requires it like this: ```ruby require 'http-parser/ext' ``` I'll try to send a PR soon and there's no urgency on my side. Thanks for the quick reply!