Skip to content

Commit ce831fd

Browse files
authored
Remove MODULE.bazel version bump from release process (bazelbuild#2017)
It turns out it really doesn't matter what this version is in the repo, so we can simplify our release process a bit by not needing to generate this file, or merge a PR updating it
1 parent 4b4f645 commit ce831fd

File tree

4 files changed

+1
-39
lines changed

4 files changed

+1
-39
lines changed

.github/update-module-version.sh

-21
This file was deleted.

.github/workflows/create-release.yml

-12
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,6 @@ jobs:
1818
run: |
1919
set -euo pipefail
2020
21-
git config user.name "Automatic version bump"
22-
git config user.email "[email protected]"
23-
24-
./.github/update-module-version.sh "$TAG"
25-
tmp_branch="$(uuidgen)"
26-
git checkout -b "$tmp_branch"
27-
git add MODULE.bazel
28-
msg="Update MODULE.bazel to $TAG"
29-
git commit -m "$msg"
30-
git push -u origin "$tmp_branch"
31-
gh pr create --title "$msg" --body ""
32-
3321
COPYFILE_DISABLE=1 tar czvf "rules_apple.$TAG.tar.gz" ./*
3422
./.github/generate-notes.sh "$TAG" | tee notes.md
3523
gh release create "$TAG" --title "$TAG" --target "$GITHUB_REF_NAME" --notes-file notes.md "rules_apple.$TAG.tar.gz"

MAINTENANCE.md

-2
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,6 @@ is the recommended process:
112112
- Update the `apple/repositories.bzl` and `MODULE.bazel` files in `rules_apple` with the new
113113
`apple_support` and `rules_swift` releases.
114114
- Repeat the steps above to create a release on `rules_apple`.
115-
- Merge the automatically submitted PRs that update the `MODULE.bazel`
116-
versions.
117115

118116
### Notes
119117

MODULE.bazel

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
1-
# Generated by update-module-version.sh. DO NOT EDIT.
21
module(
32
name = "rules_apple",
4-
version = "2.4.1",
3+
version = "0",
54
bazel_compatibility = [">=6.0.0"],
65
compatibility_level = 1,
76
repo_name = "build_bazel_rules_apple",
87
)
98

10-
# --- End generated content
11-
129
bazel_dep(name = "bazel_skylib", version = "1.3.0")
1310
bazel_dep(name = "apple_support", version = "1.7.1", repo_name = "build_bazel_apple_support")
1411
bazel_dep(name = "rules_swift", version = "1.9.1", repo_name = "build_bazel_rules_swift")

0 commit comments

Comments
 (0)