Skip to content

Commit 308e4b5

Browse files
committed
Build: Simplify Gruntfile constructions
Fixes jquerygh-3246
1 parent 9c90be9 commit 308e4b5

File tree

5 files changed

+41
-31
lines changed

5 files changed

+41
-31
lines changed

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
.bower.json
99
.sizecache.json
1010

11-
npm-debug.log
11+
npm-debug.log*
1212

1313
# Ignore everything in dist folder except for eslint config
1414
/dist/*
15-
!/dist/.eslintrc
15+
!/dist/.eslintrc.json
1616

1717
/node_modules
1818

.npmignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.eslintignore
2-
.eslintrc
2+
.eslintrc.json
33

44
/.editorconfig
55
/.gitattributes

Gruntfile.js

+35-25
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,15 @@ module.exports = function( grunt ) {
113113
// See https://github.com/sindresorhus/grunt-eslint/issues/119
114114
quiet: true
115115
},
116-
dist: "dist/jquery.js",
117-
dev: [ "src/**/*.js", "Gruntfile.js", "test/**/*.js", "build/**/*.js" ]
116+
117+
// We have to explicitly declare "src" property otherwise "newer"
118+
// task wouldn't work properly :/
119+
dist: {
120+
src: "dist/jquery.js"
121+
},
122+
dev: {
123+
src: [ "src/**/*.js", "Gruntfile.js", "test/**/*.js", "build/**/*.js" ]
124+
}
118125
},
119126
testswarm: {
120127
tests: [
@@ -148,7 +155,7 @@ module.exports = function( grunt ) {
148155
]
149156
},
150157
watch: {
151-
files: [ "<%= eslint.dev %>" ],
158+
files: [ "<%= eslint.dev.src %>" ],
152159
tasks: [ "dev" ]
153160
},
154161
uglify: {
@@ -196,36 +203,39 @@ module.exports = function( grunt ) {
196203

197204
grunt.registerTask( "lint", [
198205
"jsonlint",
199-
runIfNewNode( "eslint:dev" ),
200-
runIfNewNode( "eslint:dist" )
206+
runIfNewNode( "eslint" )
201207
] );
202208

203-
grunt.registerTask( "test_fast", [ runIfNewNode( "node_smoke_tests" ) ] );
209+
grunt.registerTask( "lint:newer", [
210+
"newer:jsonlint",
211+
runIfNewNode( "newer:eslint" )
212+
] );
204213

205-
grunt.registerTask( "test", [ "test_fast" ].concat(
206-
[ runIfNewNode( "promises_aplus_tests" ) ]
207-
) );
214+
grunt.registerTask( "test:fast", runIfNewNode( "node_smoke_tests" ) );
215+
grunt.registerTask( "test:slow", runIfNewNode( "promises_aplus_tests" ) );
216+
217+
grunt.registerTask( "test", [
218+
"test:fast",
219+
"test:slow"
220+
] );
208221

209-
// Short list as a high frequency watch task
210222
grunt.registerTask( "dev", [
211-
"build:*:*",
212-
runIfNewNode( "newer:eslint:dev" ),
213-
"uglify",
214-
"remove_map_comment",
215-
"dist:*"
216-
]
217-
);
223+
"build:*:*",
224+
runIfNewNode( "newer:eslint:dev" ),
225+
"newer:uglify",
226+
"remove_map_comment",
227+
"dist:*",
228+
"compare_size"
229+
] );
218230

219231
grunt.registerTask( "default", [
220-
"dev",
232+
runIfNewNode( "eslint:dev" ),
233+
"build:*:*",
234+
"uglify",
235+
"remove_map_comment",
236+
"dist:*",
221237
runIfNewNode( "eslint:dist" ),
222-
"test_fast",
238+
"test:fast",
223239
"compare_size"
224240
] );
225-
226-
grunt.registerTask( "precommit_lint", [
227-
"newer:jsonlint",
228-
runIfNewNode( "newer:eslint:dev" ),
229-
runIfNewNode( "newer:eslint:dist" )
230-
] );
231241
};

dist/.eslintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "../src/.eslintrc",
33
"rules": {
4-
// That is okay for built version
4+
// That is okay for the built version
55
"no-multiple-empty-lines": "off",
66

77
// Because sizze is not compatible to jquery code style

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
"scripts": {
6161
"build": "npm install && grunt",
6262
"start": "grunt watch",
63-
"test": "grunt && grunt test",
64-
"precommit": "grunt precommit_lint",
63+
"test": "grunt && grunt test:slow",
64+
"precommit": "grunt lint:newer",
6565
"commitmsg": "node node_modules/commitplease"
6666
},
6767
"commitplease": {

0 commit comments

Comments
 (0)