Skip to content

Commit c42f746

Browse files
committed
fix(testing): replace react dom with testing-library/react
1 parent 3c428fa commit c42f746

File tree

4 files changed

+42
-5
lines changed

4 files changed

+42
-5
lines changed

.husky/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
_
1+
_

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
"@storybook/addon-links": "^6.1.16",
6868
"@storybook/addons": "^6.1.16",
6969
"@storybook/react": "^6.1.16",
70+
"@testing-library/react": "^11.2.6",
7071
"@testing-library/react-hooks": "^5.0.3",
7172
"@tippyjs/react": "^4.2.0",
7273
"@types/dom-inputevent": "^1.0.6",

test/renders.test.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { render } from '@testing-library/react';
12
import * as React from 'react';
2-
import * as ReactDOM from 'react-dom';
33
import { Editable, Slate } from 'slate-react';
44
import { useSlateState, useSlateWithExtensions } from '../dist';
55

@@ -25,8 +25,7 @@ describe('useSlateWithExtensions', () => {
2525
</Slate>
2626
);
2727
};
28-
const div = document.createElement('div');
29-
ReactDOM.render(<BasicExample />, div);
30-
ReactDOM.unmountComponentAtNode(div);
28+
render(<BasicExample />);
29+
expect(1).toBe(1);
3130
});
3231
});

yarn.lock

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2734,6 +2734,20 @@
27342734
resolve-from "^5.0.0"
27352735
store2 "^2.12.0"
27362736

2737+
"@testing-library/dom@^7.28.1":
2738+
version "7.30.3"
2739+
resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-7.30.3.tgz#779ea9bbb92d63302461800a388a5a890ac22519"
2740+
integrity sha512-7JhIg2MW6WPwyikH2iL3o7z+FTVgSOd2jqCwTAHqK7Qal2gRRYiUQyURAxtbK9VXm/UTyG9bRihv8C5Tznr2zw==
2741+
dependencies:
2742+
"@babel/code-frame" "^7.10.4"
2743+
"@babel/runtime" "^7.12.5"
2744+
"@types/aria-query" "^4.2.0"
2745+
aria-query "^4.2.2"
2746+
chalk "^4.1.0"
2747+
dom-accessibility-api "^0.5.4"
2748+
lz-string "^1.4.4"
2749+
pretty-format "^26.6.2"
2750+
27372751
"@testing-library/react-hooks@^5.0.3":
27382752
version "5.1.1"
27392753
resolved "https://registry.yarnpkg.com/@testing-library/react-hooks/-/react-hooks-5.1.1.tgz#1fbaae8a4e8a4a7f97b176c23e1e890c41bbbfa5"
@@ -2746,6 +2760,14 @@
27462760
filter-console "^0.1.1"
27472761
react-error-boundary "^3.1.0"
27482762

2763+
"@testing-library/react@^11.2.6":
2764+
version "11.2.6"
2765+
resolved "https://registry.yarnpkg.com/@testing-library/react/-/react-11.2.6.tgz#586a23adc63615985d85be0c903f374dab19200b"
2766+
integrity sha512-TXMCg0jT8xmuU8BkKMtp8l7Z50Ykew5WNX8UoIKTaLFwKkP2+1YDhOLA2Ga3wY4x29jyntk7EWfum0kjlYiSjQ==
2767+
dependencies:
2768+
"@babel/runtime" "^7.12.5"
2769+
"@testing-library/dom" "^7.28.1"
2770+
27492771
"@tippyjs/react@^4.2.0":
27502772
version "4.2.5"
27512773
resolved "https://registry.yarnpkg.com/@tippyjs/react/-/react-4.2.5.tgz#9b5837db93a1cac953962404df906aef1a18e80d"
@@ -2758,6 +2780,11 @@
27582780
resolved "https://registry.yarnpkg.com/@types/anymatch/-/anymatch-1.3.1.tgz#336badc1beecb9dacc38bea2cf32adf627a8421a"
27592781
integrity sha512-/+CRPXpBDpo2RK9C68N3b2cOvO0Cf5B9aPijHsoDQTHivnGSObdOF2BRQOYjojWTDy6nQvMjmqRXIxH55VjxxA==
27602782

2783+
"@types/aria-query@^4.2.0":
2784+
version "4.2.1"
2785+
resolved "https://registry.yarnpkg.com/@types/aria-query/-/aria-query-4.2.1.tgz#78b5433344e2f92e8b306c06a5622c50c245bf6b"
2786+
integrity sha512-S6oPal772qJZHoRZLFc/XoZW2gFvwXusYUmXPXkgxJLuEk2vOt7jc4Yo6z/vtI0EBkbPBVrJJ0B+prLIKiWqHg==
2787+
27612788
"@types/babel__core@^7.0.0", "@types/babel__core@^7.1.7":
27622789
version "7.1.12"
27632790
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.1.12.tgz#4d8e9e51eb265552a7e4f1ff2219ab6133bdfb2d"
@@ -5936,6 +5963,11 @@ doctrine@^3.0.0:
59365963
dependencies:
59375964
esutils "^2.0.2"
59385965

5966+
dom-accessibility-api@^0.5.4:
5967+
version "0.5.4"
5968+
resolved "https://registry.yarnpkg.com/dom-accessibility-api/-/dom-accessibility-api-0.5.4.tgz#b06d059cdd4a4ad9a79275f9d414a5c126241166"
5969+
integrity sha512-TvrjBckDy2c6v6RLxPv5QXOnU+SmF9nBII5621Ve5fu6Z/BDrENurBEvlC1f44lKEUVqOpK4w9E5Idc5/EgkLQ==
5970+
59395971
dom-converter@^0.2:
59405972
version "0.2.0"
59415973
resolved "https://registry.yarnpkg.com/dom-converter/-/dom-converter-0.2.0.tgz#6721a9daee2e293682955b6afe416771627bb768"
@@ -9680,6 +9712,11 @@ lru-cache@^6.0.0:
96809712
dependencies:
96819713
yallist "^4.0.0"
96829714

9715+
lz-string@^1.4.4:
9716+
version "1.4.4"
9717+
resolved "https://registry.yarnpkg.com/lz-string/-/lz-string-1.4.4.tgz#c0d8eaf36059f705796e1e344811cf4c498d3a26"
9718+
integrity sha1-wNjq82BZ9wV5bh40SBHPTEmNOiY=
9719+
96839720
magic-string@^0.25.2, magic-string@^0.25.7:
96849721
version "0.25.7"
96859722
resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.25.7.tgz#3f497d6fd34c669c6798dcb821f2ef31f5445051"

0 commit comments

Comments
 (0)