-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GH actions to deploy to Firebase on merge to master #13
Comments
ive been able to deploy to heroku using github actions, i'm sure firebase deploy would be much easier, updating the db as in pulling down the student json might be a little tricky though |
I think updating the db would be as "simple" as grabbing the files in |
Oh you mean uploading the json, not downloading it, gotcha. The problem with that is the pre-work scraper updates it on firebase, so everytime you would upload the json file the percentages would reset |
yeah so the flow would change for that. The scraper would update a local file(s), then you'd create a PR. That way every dev wouldn't have to download the JSON from firebase before starting work, they'd just need to keep GH updated. |
Current issue: the apiKeys file is needed in the build, so that currently fails on CD. Couple of options:
number 2 is probably the way to go...because number 1 seems pretty hacky. Or we can just close this and accept that we need to manually build/deploy 🙃 |
in the meantime I've disabled actions, so they won't run and fail all the time, until I can circle back to this |
Also update the db?
The text was updated successfully, but these errors were encountered: