KDE Workaround to focus issues

[gfgit]

In #1975 we hit QTBUG-52021

This is because panel window does not accept focus (See panel/lxqtpanel.cpp#L152)

This line was added inside commit 63accd3

Current situation:

• Qt Bug is fixed for Qt 6.6 version
• We should investigate if mentioned commit is still valid in Qt6 and in future on wayland
• Possible KDE related workaround: https://invent.kde.org/plasma/plasma-workspace/-/commit/d942456b2aa08eaa1bc6e6bece0b2c04e4ad4223

[tsujan]

Is this our issue? If yes, please describe it. If no, https://github.com/lxqt/lxqt/discussions is the best place for it.

EDIT:
Thanks for adding an explanation to your report!

[stefonarch]

If I get things right also on wayland a panel should not have focus while atm lxqt-panel takes focus if clicked somewhere, menu or not, while waybar, yatbfw or sfwbar do not, so this commit doesn't ever work on wayland, x11 only. But they have no menu to write or search in.

On wayland with layershell-qt this is can be achieved using

    /**
     * This enum type is used to specify how the layer surface handles keyboard focus.
     */
    enum KeyboardInteractivity {
        KeyboardInteractivityNone = 0,
        KeyboardInteractivityExclusive = 1,
        KeyboardInteractivityOnDemand = 2,
    };

[tsujan]

Window::KeyboardInteractivityNone had a nasty problem that prevented the panel's children from getting the focus.

Now, at least with Qt 6.8 and under kwin_wayland, it works like a charm, such that I was able to remove the workaround mentioned in #2116 here.

@stefonarch
You have a complete collection of Wayland compositors. Would you test it under them and see if the children can get the focus? If it works with well-known compositors that are important to us, we could use it and get rid of a focused panel under Wayland.

[stefonarch]

I tested all (except kwin which you did afaik).
Unfortunately only wayfire and Hyprland give focus to the menus (arrow keys and input field in Fancy menu), river, sway, niri and labwc not.

Don't know if we can change to OnDemand on opening menus.

[tsujan]

Unfortunately only wayfire and Hyprland give focus to the menus

And kwin_wayland.

I'm getting suspicious of a problem in the other compositors, including my favorite, labwc.

[tsujan]

Done in 0d0d14b, for well-behaving Wayland compositors like kwin_wayland.

[stefonarch]

Looks like we forgot to close this? Or let it open as reminder?

[tsujan]

Or let it open as reminder?

I'm using kwin_wayland for a while, and everything is OK. Panel's not accepting focus is the correct behavior, not a bug (that exists under labwc).

[stefonarch]

The title is somehow misleading as it the focus issue is present still on Niri, wayfire and some others.

[tsujan]

That's not our issue. It should be reported to the devs of those compositors. I reported it to labwc a long time ago. I'm sure Wayfire dev(s) won't do anything about it. Don't know about the others.

In kwin_wayland, everything works as expected, and the report was about it.

[tsujan]

Also, see #2153 for why we can set KeyboardInteractivityNone only for some compositors.

It's set for Wayfire, BTW. If it causes a problem there, please tell me to remove it for Wayfire.

In short, a good panel shouldn't get the focus, whether on X11 or on Wayland, but that's not possible with all Wayland compositors for now.

EDIT: Oh, everything was already explained in previous comments of this page ;)