Skip to content

Commit 228aafa

Browse files
committed
fix
1 parent 84269d7 commit 228aafa

File tree

6 files changed

+38
-20
lines changed

6 files changed

+38
-20
lines changed

README.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,20 @@ Please See [Documentation](https://gokart.readthedocs.io/en/latest/) .
8787

8888
Have a good gokart life.
8989

90+
# Contributing to gokart
91+
92+
install
93+
94+
```bash
95+
git clone https://github.com/m3dev/gokart.git # or your own fork
96+
97+
poetry install --extra s3 --extra gcs --with dev-s3
98+
```
99+
100+
test
101+
102+
```
103+
```
90104
# Achievements
91105

92106
Gokart is a proven product.

docs/intro_to_gokart.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ Within the activated Python environment, use the following command to install go
1010
.. code:: sh
1111
1212
pip install gokart
13+
# or
14+
pip install gokart[s3] # to use `s3://`
15+
# or
16+
pip install gokart[gcs] # to use `gs://`
1317
1418
1519

gokart/object_storage.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ def assert_gcs_available():
3232
if GCS_AVAILABLE:
3333
return
3434

35-
raise ImportError('gs:// is not available. Please install gokart[gcs]')
35+
raise ImportError('gs:// is not available. You may need `pip install gokart[gcs]`')
3636

3737

3838
def assert_s3_available():
3939
if S3_AVAILABLE:
4040
return
4141

42-
raise ImportError('s3:// is not available. Please install gokart[s3]')
42+
raise ImportError('s3:// is not available. You may need `pip install gokart[s3]`')
4343

4444

4545
class ObjectStorage(object):

poetry.lock

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ google-api-python-client = {version = "*", optional = true}
2929
APScheduler = "*"
3030
redis = "*"
3131
matplotlib = "*"
32-
pytest = "*"
3332

3433
[tool.poetry.group.dev.dependencies]
3534
pyproject-flake8 = "5.0.4"
@@ -43,10 +42,11 @@ lupa = "*"
4342
fakeredis = "*"
4443
mypy = "*"
4544
types-redis = "*"
45+
pytest = "*"
4646

47-
# for dev, extra is installed by default
48-
[tool.poetry.group.dev-extra.dependencies]
49-
google-api-python-client = "*"
47+
[tool.poetry.group.dev-s3]
48+
optional = true
49+
[tool.poetry.group.dev-s3.dependencies]
5050
moto = "*"
5151

5252
[tool.poetry.extras]

tox.ini

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ isolated_build = true
66
allowlist_externals = poetry, pytest
77
skip_install = true
88
commands =
9-
s3: poetry install -E s3 --without=dev-extra
9+
s3: poetry install --extra s3 --with=dev-s3
1010
s3: pytest -v -m "s3"
1111

12-
gcs: poetry install -E gcs --without=dev-extra
12+
gcs: poetry install --extra gcs
1313
gcs: pytest -v -m "gcs"
1414

15-
core: poetry install --without=dev-extra
15+
core: poetry install
1616
core: pytest -v -m "not gcs and not s3"
1717

1818
[testenv:yapf]

0 commit comments

Comments
 (0)