Skip to content

test: convert .then to async/await in legacy-alias-request test #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

test: convert .then to async/await in legacy-alias-request test #1088

merged 2 commits into from
Oct 9, 2025

Conversation

@jaissica12
Copy link
Contributor

@jaissica12 jaissica12 commented Oct 7, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated all occurrences of .then to async/await within legacy-alias-request test

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 requested a review from rmi22186 October 7, 2025 20:05
@jaissica12 jaissica12 marked this pull request as ready for review October 7, 2025 20:05
rmi22186
rmi22186 requested changes Oct 9, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update async() ----> () where not needed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jaissica12 jaissica12 requested a review from rmi22186 October 9, 2025 13:45
@jaissica12 jaissica12 merged commit edb0ab7 into test/SDKE-300-convert-all-then-to-async-await-in-tests Oct 9, 2025
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaissica12 @rmi22186