Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLH block-feedback #74

Open
goerz opened this issue May 22, 2018 · 2 comments
Open

SLH block-feedback #74

goerz opened this issue May 22, 2018 · 2 comments
Assignees
Labels
documentation needs documentation enhancement new or improved features printing enhancements to the printing system

Comments

@goerz
Copy link
Member

goerz commented May 22, 2018

Since we have worked out the SLH rule for applying feedback to a whole block of output channels at once, this should be implemented in the circuit_algebra module.

We might also want to lift the restriction that Feedback can only happen from the bottom output channel (this adds needless permutations that make the resulting SLH expressions more complicated).

The printing and circuit visualization will also have to be modified, but we can internally expand the block-feedback into nested feedbacks to make this easy. Lastly, the documentation needs to be reviewed.

@goerz goerz added enhancement new or improved features documentation needs documentation printing enhancements to the printing system labels May 22, 2018
@goerz
Copy link
Member Author

goerz commented May 22, 2018

@danielwe Can I assign you to this issue?

@danielwe
Copy link
Contributor

That's OK. There will be about 4 weeks until I can start working on it.

(Note that on more careful reading, multiple channel feedback was always there in the original references. Due to the generality and redundancy of the abstract formalism it is actually admitted on two separate levels.)

We''l see what turns out to be the best approach: a single permutation step to bring all the lines into a contiguous corner block, or the more direct solution of building a non-diagonal adjacency matrix (essentially permuting the I in I - S_{ff} instead).

For visualization I think we should avoid expanding to nested single channel feedbacks. That does not result in the circuit diagram we want to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needs documentation enhancement new or improved features printing enhancements to the printing system
Projects
None yet
Development

No branches or pull requests

2 participants