Fails to build against OpenSSL version 1.1.0g

[erikd]

#Configure fails at:

checking openssl/evp.h usability... yes
checking openssl/evp.h presence... yes
checking for openssl/evp.h... yes
checking for OpenSSL_add_all_ciphers in -lcrypto... no
configure: error: Cannot build without libcrypto (OpenSSL)
Error 0 in ./configure

I have OpenSSL version 1.1.0g instatlled.

I'd fix this, but I'm already to deep down the yak stack.

[eshwarz]

@erikd do we have a work around for this?

[erikd]

We? I don't. No idea if anyone else does.

[armijnhemel]

In OpenSSL 1.1.x the function OpenSSL_add_all_ciphers was deprecated and replaced with OPENSSL_init_crypto:

https://www.openssl.org/docs/man1.1.0/crypto/OpenSSL_add_all_ciphers.html

in configure.ac I replaced the OpenSSL_add_all_ciphers line with this:

AC_CHECK_LIB([crypto], [OPENSSL_init_crypto], , [have_libcrypto="0"])

then reran autogen.sh and that fixes the build for me on Fedora 26. At first glance xar seems to run fine.

[erikd]

@armijnhemel Would be great if could you raise a PR with those changes.

[armijnhemel]

I will first need to run a few more tests to see if it actually works as expected before I create a PR. Also, this change will break building with openssl 1.0.x and I would also need to work around that.

[erikd]

Obviously, this is not my project, but I honestly don't think backwards compatibility with an older version of OpenSSL is an important factor. OpenSSL is an important security related library with a somewhat checkered history security wise. Supporting old, possible broken versions doesn't make a lot of sense, especially since 1.1.* has been out for for over a year. See https://www.openssl.org/news/openssl-1.1.0-notes.html

[janpio]

The change @ErikGoldman did here https://github.com/loft-box-labs/xar/commit/bab8837fd993385115d58763e15487dc8cc13f97 (probably via #18 (comment)) worked perfectly for me.