Skip to content

Commit f9a6550

Browse files
committed
patch 8.2.2570: tests fail when run as root
Problem: Tests fail when run as root. Solution: Add a comment mentioning the expected failure. (issue #7919)
1 parent 008bff9 commit f9a6550

File tree

5 files changed

+6
-0
lines changed

5 files changed

+6
-0
lines changed

src/testdir/test_edit.vim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1704,6 +1704,7 @@ func Test_edit_charconvert()
17041704
endfunc
17051705

17061706
" Test for editing a file without read permission
1707+
" NOTE: if you run tests as root this will fail. Don't run tests as root!
17071708
func Test_edit_file_no_read_perm()
17081709
CheckUnix
17091710
call writefile(['one', 'two'], 'Xfile')

src/testdir/test_excmd.vim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ func Test_winsize_cmd()
333333
endfunc
334334

335335
" Test for the :redir command
336+
" NOTE: if you run tests as root this will fail. Don't run tests as root!
336337
func Test_redir_cmd()
337338
call assert_fails('redir @@', 'E475:')
338339
call assert_fails('redir abc', 'E475:')

src/testdir/test_help.vim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ func Test_help_completion()
7474
endfunc
7575

7676
" Test for the :helptags command
77+
" NOTE: if you run tests as root this will fail. Don't run tests as root!
7778
func Test_helptag_cmd()
7879
call mkdir('Xdir/a/doc', 'p')
7980

src/testdir/test_writefile.vim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ func Test_patchmode()
406406
endfunc
407407

408408
" Test for writing to a file in a readonly directory
409+
" NOTE: if you run tests as root this will fail. Don't run tests as root!
409410
func Test_write_readonly_dir()
410411
" On MS-Windows, modifying files in a read-only directory is allowed.
411412
CheckUnix

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,8 @@ static char *(features[]) =
750750

751751
static int included_patches[] =
752752
{ /* Add new patch number below this line */
753+
/**/
754+
2570,
753755
/**/
754756
2569,
755757
/**/

0 commit comments

Comments
 (0)