Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional breakpoints for columnset #19

Open
operatorone opened this issue Aug 30, 2021 · 9 comments
Open

Additional breakpoints for columnset #19

operatorone opened this issue Aug 30, 2021 · 9 comments

Comments

@operatorone
Copy link

Add in the option of the column wrapper additional fields for two more breakpoints. The result might look like this:

label class sample size (px)
Desktop xx-large ≥ 1440 px
Laptop x-large < 1440px
Tablet landscape large < 1200px
Tablet portrait medium < 800px
Phone landscape small < 640px
Phone x-small < 480px

The resolutions are just an example. They can be adjusted anyway. But the count of at least five breakpoints is essential. Better to have six breakpoints, so there is more flexibility.

https://github.com/madeyourday/contao-rocksolid-columns/blob/develop-v3/src/Resources/contao/dca/tl_content.php

Thanks a lot.

@operatorone
Copy link
Author

Hi, any news for this enhancement? 😉

@ausi
Copy link
Member

ausi commented Sep 15, 2021

What would you think about adding a bundle configuration for that? This way we could enable any number of breakpoints while maintaining backwards compatibility.

@operatorone
Copy link
Author

This is a great idea. In projects, it differs a lot what the recommendations for responsiveness are and with that way, you can match every need.

@landzone21
Copy link

Can you already say, when an implementation will be available?

@operatorone
Copy link
Author

Any news on this?

@operatorone
Copy link
Author

Still no news? 😉

@rabauss
Copy link
Contributor

rabauss commented Nov 30, 2022

@ausi obviously, in v3 there are now the following columns implemented: xlarge, large, medium, small, xsmall - so two more breakpoints than in v2 👍

what's your idea of a bundle config? would you add a config for reusable named column sets which you can pick/select in content elements and with #4 maybe also in forms?

@ausi
Copy link
Member

ausi commented Nov 30, 2022

what's your idea of a bundle config?

I thought of configuring the number of breakpoints (and maybe the corresponding max-width). The problem with a bundle config is, that you cannot have different settings per theme. So I’m not sure what the best solution is here. Mabe just adding xlarge and xsmall is the more feasible solution.

@operatorone
Copy link
Author

I think it's the best way just to have at least these 5 inputs for columns and don't offer a flexible configuration. I asume you can cover a very big share of needs with that method already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants