Repository navigation
Commit 5f1c5c2
fix(julia-vase): constraints as expressions the Studio evaluates (#191)
Both constraints were written in a structured shape (parameter /
condition / value, and reference / factor) that nothing reads: the Studio's
useConstraints takes `expression` (or the legacy `rule`) and skips an
entry that has neither, so neither rule ever fired. No other consumer reads
that shape (yantra4d apps/ and the keystone src/ have no reader for
condition / factor). Rewritten as the expression the fields spelled out:
wall_thickness >= 0.8 and wave_amplitude < base_radius * 0.333, the
declared factor kept as written. Severity and both messages are unchanged.
The ripple_vase preset (wave_amplitude 15, base_radius default 40, so the
bound is 13.32) now lights the warning. It is a warning, and the house rule
only requires presets to satisfy error constraints; the preset is left as
it is.
Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 9db8c26 commit 5f1c5c2
1 file changed
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
299 | | - | |
300 | | - | |
| 298 | + | |
301 | 299 | | |
302 | 300 | | |
303 | 301 | | |
304 | 302 | | |
305 | 303 | | |
306 | 304 | | |
307 | 305 | | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
| 306 | + | |
312 | 307 | | |
313 | 308 | | |
314 | 309 | | |
| |||
0 commit comments