Tracking issues for core-foundation-rs issues/PRs
#719
Labels
A-framework
Affects the framework crates and the translator for them
documentation
Improvements or additions to documentation
Comments
madsmtm
added
the
A-framework
23 tasks
madsmtm
changed the title
core-foundation-rs issues/PRscore-foundation-rs issues/PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My work on fixing upstream issues in
core-foundation-rs(or at least opening new issues in this repo to track them). Similar to #22. See also #692.I'm a bit unsure how to handle this sort of stuff, I wanted to make sure that nothing in the
core-foundation-rsrepo is lost in the eventual migration, but I also didn't want to spam the repo with comments like "this is fixed inobjc2-core-foundation".Issues:
CGEventSetFlags.unsafe).CGEvent.datais Swift-only?CFCalendarGetIdentifierservo/core-foundation-rs#685objc2_core_foundation::CFCalendarGetIdentifieris correct.CGEventTaphelpers? #720.CGSRegionReleaseincore-graphicsprevents publishing to the Mac AppStore servo/core-foundation-rs#656CGSRegionReleaseisn't present inobjc2-core-graphics.objc2, andobjc2-core-foundationsupports this by implementingEncodefor all its types when the"objc2"feature is activated.linkfeature? servo/core-foundation-rs#651linkfeature not present inobjc2crates (I'll have to see a really compelling use-case before I add such a thing).objc2_core_foundation::CFRunLoopAddSourcedoes not accept raw pointer.objc2_core_graphics::CGImageCreatereturns anOption, so it's up to the user themselves to handle errors.libdispatch#77.objc2-io-kitis available.objc2's approach to macOS versions is different, it don't have a feature-flag per OS version, instead everything is always available, and it's up to you to only use the parts that are available on your supported OS version.rustc's deployment target is what's tested in CI, and I regularly test on an old MacBook with macOS 10.12 installed.objc2crates don't useforeign-types.objc2-core-foundationprovidesCFArray::to_vecand array iterators which are safer and retains like you'd expect.objc2_app_kit::NSAlertis available.objc2_core_graphics::CGEventCreateKeyboardEventacceptsNoneevent source.IOSurfaceshould be inobjc2-io-surface, that's the framework it belongs to.objc2provides a lot of feature flags to tune which crates to depend on, so the dependency problem should be a non-issue there.objc2-core-graphics, feature flags are used instead to keep compile-times down.objc2_core_foundation::CFRunLoop's docs are also kinda empty. Adding some examples would be a good idea.&CGImageto&CGImageRefservo/core-foundation-rs#466objc2_core_foundation::CFRetainedmakes this distiction of ownership clear, and avoids unnecessary retains.objc2_core_graphics::CGDisplayStreamis available.CGVirtualDisplayare not available, I would accept a PR adding behind a"private"feature flag.objc2-core-foundationdoesn't provide an abstraction on top ofCGDataProvider.objc2-core-foundationworks withobjc2and Objective-C message sending.CGImagefrom a*mut CGImageservo/core-foundation-rs#373objc2doesn't useforeign-types, so this is a non-issue here.objc2_core_foundation::Typeis anunsafetrait.objc2_core_foundation::CFMutableDictionarydoes not have the listed problems (it doesn't allow safe operations when the type parameters are unknown).objc2_foundation::NSThreadis available.objc2-core-wlanis available.objc2_core_foundation::CFRunLoopObserverfunctions are safe exceptCFRunLoopObserverCreate[WithHandler], since the callbacks must be thread-safe, and that's hard to ensure.CGDisplayMode::all_display_modessegmentation fault servo/core-foundation-rs#319core_graphics::CGDisplayMode::all_display_modesends up taking ownership of more than it should.objc2_core_graphics::CGDisplayCopyAllDisplayModesdoes not have this issue.objc2-core-foundationintentionally does not provideCFArray::from_copyable.objc2_app_kit::NSApplicationActivationOptionsusesbitflags!.objc2's header translator. See also Figure out naming scheme in framework crates #284.objc2-core-graphicsis a single crate. Incompatible dependency versions are unfortunate, but IMO better mitigated with infrequent releases.CAMetalLayercan be set as the layer inobjc2_app_kit::NSView::setLayer.CGDisplayservo/core-foundation-rs#218objc2_core_foundation::CFDictionarycan be converted fromCFDictionary<K, V>with.as_opaque().objc2_core_foundation::CFMutableArrayis available.objc2::define_class!is available.objc2's header translator creates newtypes.CGDataProviderabstraction could be useful.objc2_foundation::NSURLandobjc2_foundation::NSModalResponseare available.-[NSEvent characters].objc2::define_class!.objc2::extern_class!.DropforNSAutoreleasePool? servo/core-foundation-rs#179objc2::rc::autoreleasepoolis available, that's the only (barely) sound API.[NSEvent type]produces value21with no associatedNSEventTypevariant causing SEGFAULT. servo/core-foundation-rs#178objc2_app_kit::NSEventTypeis a struct overNSUIntegerinstead of an enum.initWithFrame_servo/core-foundation-rs#177cocoa's handling of methods as traits, not an issue inobjc2crates.-[NSStatusBar systemStatusBar].objc2has automatically generated bindings.objc2's header translator creates newtypes.objc2-core-graphicsdoesn't try to serialize for you.[NSEvent type]produces value21with no associatedNSEventTypevariant causing SEGFAULT. servo/core-foundation-rs#401[NSEvent type]produces value21with no associatedNSEventTypevariant causing SEGFAULT. servo/core-foundation-rs#178.objc2-core-foundationhas comments on most casts).PRs:
CGEventTaphelpers? #720.CGEventTaphelpers? #720.CGEventSourceGetLocationis private API not even available in.tbdfiles.core_graphics::private::CGSRegionservo/core-foundation-rs#700CGSRegionis not present inobjc2-core-graphics.Applicatin->Applicationservo/core-foundation-rs#696objc2_app_kit::NSDockTileis auto-generated, and does contain such typos.CGEventTapcallback returns nullptr servo/core-foundation-rs#665CGEventTaphelpers? #720.objc2_app_kit::NSColor.objc2-core-graphics.objc2_core_foundation::CFRunLoopAddSourcedoes not accept raw pointer.objcwithobjc2servo/core-foundation-rs#628objc2.objc2_core_foundation::CFRangeMakeis not available, should be added for documentation purposes.no_stdenvironment servo/core-foundation-rs#609no_stdis supported inobjc2-core-foundation, thoughobjc2doesn't support it.objc2::rc::Retained::<objc2_quartz_core::CALayer>::from_raw.objc2-core-text, PRs for wrappers welcome.objc2more idiomatically servo/core-foundation-rs#514objc2.CGEventTaphelpers? #720.objc2-core-text, PRs for wrappers welcome.objc2-core-text, PRs for wrappers welcome.objc2_core_graphics::CGFontCopyVariations.objc2-core-textAPIs that I don't really plan on exposing.objc2-image-io.The text was updated successfully, but these errors were encountered: