Skip to content

Commit 3fdd1aa

Browse files
author
devopsmash
committed
Allow overwrite “accessModes” to support AWS ebs for k8s volumes
1 parent d405b96 commit 3fdd1aa

File tree

3 files changed

+22
-11
lines changed

3 files changed

+22
-11
lines changed

charts/mageai/templates/deployment.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ spec:
118118
value: postgresql://{{ .Values.postgresql.auth.username }}:{{ .Values.postgresql.auth.password }}@{{ .Values.postgresql.fullnameOverride }}:5432/{{ .Values.postgresql.auth.database }}
119119
{{- end }}
120120
volumeMounts:
121-
{{- if .Values.volumes }}
121+
{{- if or .Values.volumes (and .Values.persistence .Values.persistence.enabled) }}
122122
- name: mage-fs
123123
mountPath: /home/src
124124
{{- else if .Values.extraVolumeMounts }}
@@ -140,9 +140,15 @@ spec:
140140
{{- toYaml . | nindent 8 }}
141141
{{- end }}
142142
volumes:
143+
{{- if and .Values.persistence .Values.persistence.enabled }}
144+
- name: mage-fs
145+
persistentVolumeClaim:
146+
claimName: "pvc-{{ include "mageai.fullname" . }}"
147+
{{- end }}
143148
{{- if .Values.volumes }}
144149
{{- toYaml .Values.volumes | nindent 8 }}
145-
{{- else if .Values.extraVolumes -}}
150+
{{- end }}
151+
{{- if .Values.extraVolumes -}}
146152
{{ toYaml .Values.extraVolumes | nindent 8 }}
147153
{{- end }}
148154
{{- end }}

charts/mageai/templates/pv.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ spec:
1212
storage: {{ .Values.persistence.size}}
1313
volumeMode: Filesystem
1414
accessModes:
15-
- ReadWriteMany
15+
{{- toYaml .Values.persistence.accessModes | nindent 4 }}
1616
persistentVolumeReclaimPolicy: Retain
1717
storageClassName: {{ .Values.persistence.storageClassName}}
1818
{{- with .Values.persistence.csi }}
@@ -28,7 +28,7 @@ metadata:
2828
name: pvc-{{ include "mageai.fullname" . }}
2929
spec:
3030
accessModes:
31-
- ReadWriteMany
31+
{{- toYaml .Values.persistence.accessModes | nindent 4 }}
3232
storageClassName: {{ .Values.persistence.storageClassName}}
3333
resources:
3434
requests:

charts/mageai/values.yaml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,19 +176,24 @@ tolerations: []
176176

177177
affinity: {}
178178

179-
extraVolumeMounts:
180-
- name: mage-fs
181-
mountPath: /home/src
179+
# Configure extra volumes
180+
extraVolumeMounts: []
181+
# - name: mage-fs
182+
# hostPath:
183+
# path: /path/to/mage_project
182184

183-
extraVolumes:
184-
- name: mage-fs
185-
hostPath:
186-
path: /path/to/mage_project
185+
# Mount a custom volume to support persistence to additional paths in containers' file system
186+
extraVolumes: []
187+
# - name: mage-fs
188+
# mountPath: /home/src
187189

188190
persistence:
189191
enabled: false
190192
storageClassName: storage-class-name
191193
size: 5Gi
194+
accessModes:
195+
- ReadWriteMany
196+
# dynamicProvisioning: true
192197
# csi:
193198
# driver: efs.csi.aws.com
194199
# volumeHandle: fs-0123456789

0 commit comments

Comments
 (0)