Windows Compatibility: [ERROR] Command failed

[rafal-kos]

Hello,

I am trying to run the tool on windows Git Bash :
vendor/bin/cache-clean.js config full_page
but in result I have this error :
[ERROR] Command failed: php -r 'echo json_encode((require "D:\projects\example\magento/app/etc/env.php") ?? []);'

Looks like there a problem with slash. When I run this command
php -r 'echo json_encode((require "D:/projects/example/magento/app/etc/env.php") ?? []);'
I am getting correct results.

Is it possible to get some fix for hat? Thanks in advance.

[Vinai]

Thanks for opening the issue, I‘ll push a branch some time soon and then would like to ask you to test if it works for you.

[rafal-kos]

OK. Thanks for info.

[Vinai]

I require your help to get the tool working on windows.
Can you please install the win-compatibility branch and let me know how that works?

composer remove --dev mage2tv/magento-cache-clean
composer require --dev mage2tv/magento-cache-clean:dev-win-compatibility

I expect a new error to occur. I'll try to fix one after the other until it works on windows too. Please be patient with me until it works. I appreciate your help.

[rafal-kos]

I checked the new branch. Still the same issue :

[ERROR] Command failed: php -r 'echo json_encode((require "D:\projects\example\magento/app\etc\env.php") ?? []);'

[rafal-kos]

I see in file system.cljs

(defn- win? []
  (= "win32" (.-platform process)))

On my machine I am using GIT Bash (mingw64). Maybe different platform is used here? Any chance to add some debug here?

[Vinai]

According to the documentation win32 is the operating identifier returned by nodejs on any windows host.

You can see the value on your host by running the following command in your teminal

node -e 'console.log(process.platform)'

[Vinai]

Got info from third party using Win10:

aaron@AVALANCHE MINGW64 ~
$ node -e 'console.log(process.platform)'
win32

[rafal-kos]

Yes. It looks the same on my machine. Any chance to get not minified cache-clean.js? I tried to build it on WIN without success.

[Vinai]

I've pushed an update to the win-compatibility branch.
This time all file system methods get path arguments on windows with backslashes instead of slashes.
There still might be other issues though.

Could you please do me a favor and update the branch again?

composer remove --dev mage2tv/magento-cache-clean
composer require --dev mage2tv/magento-cache-clean:dev-win-compatibility

Please also run cache-clean.js --version to confirm the correct build is being used. It should display the release name 0.0.22-dev-win-compat.

I can look into creating an un-minified build, but right now I don't have the time.

[rafal-kos]

OK. There is still the same problem. I had some time to make some debug. So... problem is not directly with path but how the php is processed from the windows cmd.exe. cmd.exe is run when you call child_process.execSync(cmd)

On windows this one will not work :
php -r 'echo json_encode((require "D:\projects\example\magento\app/etc/env.php") ?? []);'
when this one works fine :
php -r "echo json_encode((require 'D:\projects\example\magento\app/etc/env.php') ?? []);"

After changing the command and running bin/cache-clean.js cache was cleaned up 😃

Problem is when I ran bin/cache-clean.js -w. Below the error
[ERROR] Command failed: php -r 'require "D:\projects\example\magento\vendor/autoload.php"; foreach ((new \Magento\Framework\Component\ComponentRegistrar)->getPaths("module") as $m) echo $m.PHP_EOL;'

In this case I suppose that you have to change slightly how the commands are run on windows. I would like to help more but closure is just out of my scope 😄

[Vinai]

Thanks for the input!
So executed command arguments have to be quoted with double strings.
That sounds possible. I'll see that I get a version ready some time soon that does that.