Skip to content

Commit 7245166

Browse files
viktymviktym
authored
Magento Quality Patches - improvement of dev experience (magento#61)
1 parent dc08373 commit 7245166

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+3352
-472
lines changed

‎bin/ece-patches

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
* Copyright © Magento, Inc. All rights reserved.
55
* See COPYING.txt for license details.
66
*/
7+
define('IS_CLOUD', true);
78
$container = require __DIR__ . '/../bootstrap.php';
89

9-
$application = new Magento\CloudPatches\Application($container);
10+
$application = new Magento\CloudPatches\ApplicationEce($container);
1011
$application->run();

‎composer.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "magento/magento-cloud-patches",
33
"description": "Provides critical fixes for Magento 2 Enterprise Edition",
44
"type": "magento2-component",
5-
"version": "1.0.5",
5+
"version": "1.0.6",
66
"license": "OSL-3.0",
77
"require": {
88
"php": "^7.0",
@@ -14,6 +14,7 @@
1414
"symfony/dependency-injection": "^3.3||^4.3",
1515
"symfony/process": "^2.1||^4.1",
1616
"symfony/proxy-manager-bridge": "^3.3||^4.3",
17+
"symfony/yaml": "^3.3||^4.0",
1718
"monolog/monolog": "^1.16",
1819
"magento/quality-patches": "^1.0.0"
1920
},

‎config/services.xml

+13-13
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<service id="Psr\Log\LoggerInterface" alias="Magento\CloudPatches\App\Logger" />
1010
<service id="Magento\CloudPatches\App\Container" autowire="false"/>
1111
<service id="Magento\CloudPatches\Filesystem\DirectoryList" autowire="false"/>
12-
<service id="Magento\QualityPatches\Info"/>
1312
<service id="Symfony\Component\Console\Helper\QuestionHelper"/>
1413
<service id="Composer\Composer"/>
1514
<service id="Magento\CloudPatches\App\GenericException" autowire="false"/>
@@ -28,11 +27,6 @@
2827
<service id="Magento\CloudPatches\Patch\Pool\RequiredPool" lazy="true"/>
2928
<service id="Magento\CloudPatches\Patch\Pool\LocalPool" lazy="true"/>
3029
<service id="Magento\CloudPatches\Patch\Status\StatusPool" autowire="false"/>
31-
<service id="statusOptionalPool" class="Magento\CloudPatches\Patch\Status\StatusPool" lazy="true">
32-
<argument key="$resolvers" type="collection">
33-
<argument type="service" id="Magento\CloudPatches\Patch\Status\OptionalResolver"/>
34-
</argument>
35-
</service>
3630
<service id="statusPool" class="Magento\CloudPatches\Patch\Status\StatusPool" lazy="true">
3731
<argument key="$resolvers" type="collection">
3832
<argument type="service" id="Magento\CloudPatches\Patch\Status\LocalResolver"/>
@@ -42,26 +36,29 @@
4236
<service id="Magento\CloudPatches\Command\Process\ShowStatus">
4337
<argument key="$statusPool" type="service" id="statusPool"/>
4438
</service>
39+
<service id="Magento\CloudPatches\Command\Process\Ece\Revert">
40+
<argument key="$statusPool" type="service" id="statusPool"/>
41+
</service>
4542
<service id="Magento\CloudPatches\Command\Process\Action\ApplyOptionalAction">
46-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
43+
<argument key="$statusPool" type="service" id="statusPool"/>
4744
</service>
4845
<service id="Magento\CloudPatches\Command\Process\Action\RevertAction">
49-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
46+
<argument key="$statusPool" type="service" id="statusPool"/>
5047
</service>
5148
<service id="Magento\CloudPatches\Command\Process\Action\ConfirmRequiredAction">
52-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
49+
<argument key="$statusPool" type="service" id="statusPool"/>
5350
</service>
5451
<service id="Magento\CloudPatches\Command\Process\Action\ProcessDeprecatedAction">
55-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
52+
<argument key="$statusPool" type="service" id="statusPool"/>
5653
</service>
5754
<service id="Magento\CloudPatches\Command\Process\Action\ReviewAppliedAction">
58-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
55+
<argument key="$statusPool" type="service" id="statusPool"/>
5956
</service>
6057
<service id="Magento\CloudPatches\Patch\RevertValidator">
61-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
58+
<argument key="$statusPool" type="service" id="statusPool"/>
6259
</service>
6360
<service id="Magento\CloudPatches\Command\Process\Renderer">
64-
<argument key="$statusPool" type="service" id="statusOptionalPool"/>
61+
<argument key="$statusPool" type="service" id="statusPool"/>
6562
</service>
6663
<service id="Magento\CloudPatches\Command\Process\Action\ActionPool" autowire="false"/>
6764
<service id="ApplyOptionalActionPool" class="Magento\CloudPatches\Command\Process\Action\ActionPool">
@@ -75,6 +72,9 @@
7572
<service id="Magento\CloudPatches\Command\Process\ApplyOptional">
7673
<argument key="$actionPool" type="service" id="ApplyOptionalActionPool"/>
7774
</service>
75+
<service id="Magento\CloudPatches\Command\Process\Ece\ApplyOptional">
76+
<argument key="$actionPool" type="service" id="ApplyOptionalActionPool"/>
77+
</service>
7878
<service id="Magento\CloudPatches\Patch\PatchBuilder" shared="false"/>
7979
</services>
8080
</container>

‎src/ApplicationEce.php

+48
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\CloudPatches;
9+
10+
use Composer\Composer;
11+
use Magento\CloudPatches\Command;
12+
use Psr\Container\ContainerInterface;
13+
14+
/**
15+
* @inheritdoc
16+
*/
17+
class ApplicationEce extends \Symfony\Component\Console\Application
18+
{
19+
/**
20+
* @var ContainerInterface
21+
*/
22+
private $container;
23+
24+
/**
25+
* @param ContainerInterface $container
26+
*/
27+
public function __construct(ContainerInterface $container)
28+
{
29+
$this->container = $container;
30+
31+
parent::__construct(
32+
$container->get(Composer::class)->getPackage()->getPrettyName(),
33+
$container->get(Composer::class)->getPackage()->getPrettyVersion()
34+
);
35+
}
36+
37+
/**
38+
* @inheritdoc
39+
*/
40+
protected function getDefaultCommands()
41+
{
42+
return array_merge(parent::getDefaultCommands(), [
43+
$this->container->get(Command\Ece\Apply::class),
44+
$this->container->get(Command\Ece\Revert::class),
45+
$this->container->get(Command\Status::class)
46+
]);
47+
}
48+
}

‎src/Command/Apply.php

+8-60
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,15 @@
88
namespace Magento\CloudPatches\Command;
99

1010
use Magento\CloudPatches\App\RuntimeException;
11-
use Magento\CloudPatches\Command\Process\ApplyLocal;
1211
use Magento\CloudPatches\Command\Process\ApplyOptional;
13-
use Magento\CloudPatches\Command\Process\ApplyRequired;
1412
use Magento\CloudPatches\Composer\MagentoVersion;
15-
use Magento\CloudPatches\Patch\Environment;
1613
use Psr\Log\LoggerInterface;
1714
use Symfony\Component\Console\Input\InputArgument;
1815
use Symfony\Component\Console\Input\InputInterface;
19-
use Symfony\Component\Console\Input\InputOption;
2016
use Symfony\Component\Console\Output\OutputInterface;
2117

2218
/**
23-
* Patch apply command.
19+
* Patch apply command (OnPrem).
2420
*/
2521
class Apply extends AbstractCommand
2622
{
@@ -30,35 +26,15 @@ class Apply extends AbstractCommand
3026
const NAME = 'apply';
3127

3228
/**
33-
* Defines whether Magento is installed from Git.
29+
* List of patches to apply.
3430
*/
35-
const OPT_GIT_INSTALLATION = 'git-installation';
36-
37-
/**
38-
* List of quality patches to apply.
39-
*/
40-
const ARG_QUALITY_PATCHES = 'quality-patches';
31+
const ARG_LIST_OF_PATCHES = 'list-of-patches';
4132

4233
/**
4334
* @var ApplyOptional
4435
*/
4536
private $applyOptional;
4637

47-
/**
48-
* @var ApplyRequired
49-
*/
50-
private $applyRequired;
51-
52-
/**
53-
* @var ApplyLocal
54-
*/
55-
private $applyLocal;
56-
57-
/**
58-
* @var Environment
59-
*/
60-
private $environment;
61-
6238
/**
6339
* @var LoggerInterface
6440
*/
@@ -70,25 +46,16 @@ class Apply extends AbstractCommand
7046
private $magentoVersion;
7147

7248
/**
73-
* @param ApplyRequired $applyRequired
7449
* @param ApplyOptional $applyOptional
75-
* @param ApplyLocal $applyLocal
76-
* @param Environment $environment
7750
* @param LoggerInterface $logger
7851
* @param MagentoVersion $magentoVersion
7952
*/
8053
public function __construct(
81-
ApplyRequired $applyRequired,
8254
ApplyOptional $applyOptional,
83-
ApplyLocal $applyLocal,
84-
Environment $environment,
8555
LoggerInterface $logger,
8656
MagentoVersion $magentoVersion
8757
) {
88-
$this->applyRequired = $applyRequired;
8958
$this->applyOptional = $applyOptional;
90-
$this->applyLocal = $applyLocal;
91-
$this->environment = $environment;
9259
$this->logger = $logger;
9360
$this->magentoVersion = $magentoVersion;
9461

@@ -101,17 +68,11 @@ public function __construct(
10168
protected function configure()
10269
{
10370
$this->setName(self::NAME)
104-
->setDescription('Apply patches')
71+
->setDescription('Applies patches. The list of patches should pass as a command argument')
10572
->addArgument(
106-
self::ARG_QUALITY_PATCHES,
107-
InputArgument::IS_ARRAY,
108-
'List of quality patches to apply'
109-
)->addOption(
110-
self::OPT_GIT_INSTALLATION,
111-
null,
112-
InputOption::VALUE_OPTIONAL,
113-
'Is git installation',
114-
false
73+
self::ARG_LIST_OF_PATCHES,
74+
InputArgument::IS_ARRAY | InputArgument::REQUIRED,
75+
'List of patches to apply'
11576
);
11677

11778
parent::configure();
@@ -122,23 +83,10 @@ protected function configure()
12283
*/
12384
public function execute(InputInterface $input, OutputInterface $output)
12485
{
125-
$deployedFromGit = $input->getOption(Apply::OPT_GIT_INSTALLATION);
126-
if ($deployedFromGit) {
127-
$output->writeln('<info>Git-based installation. Skipping patches applying.</info>');
128-
129-
return self::RETURN_SUCCESS;
130-
}
131-
13286
$this->logger->notice($this->magentoVersion->get());
13387

13488
try {
135-
if ($this->environment->isCloud()) {
136-
$this->applyRequired->run($input, $output);
137-
$this->applyOptional->run($input, $output);
138-
$this->applyLocal->run($input, $output);
139-
} else {
140-
$this->applyOptional->run($input, $output);
141-
}
89+
$this->applyOptional->run($input, $output);
14290
} catch (RuntimeException $e) {
14391
$output->writeln('<error>' . $e->getMessage() . '</error>');
14492
$this->logger->error($e->getMessage());

‎src/Command/Ece/Apply.php

+113
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\CloudPatches\Command\Ece;
9+
10+
use Magento\CloudPatches\App\RuntimeException;
11+
use Magento\CloudPatches\Command\AbstractCommand;
12+
use Magento\CloudPatches\Command\Process\ApplyLocal;
13+
use Magento\CloudPatches\Command\Process\Ece\ApplyOptional;
14+
use Magento\CloudPatches\Command\Process\ApplyRequired;
15+
use Magento\CloudPatches\Composer\MagentoVersion;
16+
use Psr\Log\LoggerInterface;
17+
use Symfony\Component\Console\Input\InputInterface;
18+
use Symfony\Component\Console\Output\OutputInterface;
19+
20+
/**
21+
* Patch apply command (Cloud).
22+
*/
23+
class Apply extends AbstractCommand
24+
{
25+
/**
26+
* Command name.
27+
*/
28+
const NAME = 'apply';
29+
30+
/**
31+
* @var ApplyOptional
32+
*/
33+
private $applyOptional;
34+
35+
/**
36+
* @var ApplyRequired
37+
*/
38+
private $applyRequired;
39+
40+
/**
41+
* @var ApplyLocal
42+
*/
43+
private $applyLocal;
44+
45+
/**
46+
* @var LoggerInterface
47+
*/
48+
private $logger;
49+
50+
/**
51+
* @var MagentoVersion
52+
*/
53+
private $magentoVersion;
54+
55+
/**
56+
* @param ApplyRequired $applyRequired
57+
* @param ApplyOptional $applyOptional
58+
* @param ApplyLocal $applyLocal
59+
* @param LoggerInterface $logger
60+
* @param MagentoVersion $magentoVersion
61+
*/
62+
public function __construct(
63+
ApplyRequired $applyRequired,
64+
ApplyOptional $applyOptional,
65+
ApplyLocal $applyLocal,
66+
LoggerInterface $logger,
67+
MagentoVersion $magentoVersion
68+
) {
69+
$this->applyRequired = $applyRequired;
70+
$this->applyOptional = $applyOptional;
71+
$this->applyLocal = $applyLocal;
72+
$this->logger = $logger;
73+
$this->magentoVersion = $magentoVersion;
74+
75+
parent::__construct(self::NAME);
76+
}
77+
78+
/**
79+
* @inheritDoc
80+
*/
81+
protected function configure()
82+
{
83+
$this->setName(self::NAME)
84+
->setDescription('Applies patches (Magento Cloud only)');
85+
86+
parent::configure();
87+
}
88+
89+
/**
90+
* @inheritDoc
91+
*/
92+
public function execute(InputInterface $input, OutputInterface $output)
93+
{
94+
$this->logger->notice($this->magentoVersion->get());
95+
96+
try {
97+
$this->applyRequired->run($input, $output);
98+
$this->applyOptional->run($input, $output);
99+
$this->applyLocal->run($input, $output);
100+
} catch (RuntimeException $e) {
101+
$output->writeln('<error>' . $e->getMessage() . '</error>');
102+
$this->logger->error($e->getMessage());
103+
104+
return self::RETURN_FAILURE;
105+
} catch (\Exception $e) {
106+
$this->logger->critical($e);
107+
108+
throw $e;
109+
}
110+
111+
return self::RETURN_SUCCESS;
112+
}
113+
}

0 commit comments

Comments
 (0)