AC-16072: PHPUnit 12: Upgrade SalesRules & other related test cases

Author: shashi011

app/code/Magento/Multishipping/Test/Unit/Block/Checkout/SuccessTest.php

@@ -7,7 +7,7 @@
 
 namespace Magento\Multishipping\Test\Unit\Block\Checkout;
 
-use Magento\Framework\Session\SessionManagerInterface;
+use Magento\Framework\Session\Generic;
 use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\View\Element\Template\Context;
@@ -42,7 +42,7 @@ class SuccessTest extends TestCase
     protected function setUp(): void
     {
         $this->sessionMock = $this->createPartialMockWithReflection(
-            \Magento\Framework\Session\Generic::class,
+            Generic::class,
             ['getOrderIds']
         );
         $this->contextMock = $this->createMock(Context::class);

app/code/Magento/Multishipping/Test/Unit/Helper/DataTest.php

@@ -37,14 +37,14 @@ class DataTest extends TestCase
     protected $scopeConfigMock;
 
     /**
-     * Quote mock
+     * Mock object for quote model
      *
      * @var MockObject|\Magento\Quote\Model\Quote
      */
     protected $quoteMock;
 
     /**
-     * Checkout session mock
+     * Mock object for checkout session
      *
      * @var MockObject|Session
      */

app/code/Magento/Multishipping/Test/Unit/Model/Payment/Method/Specification/EnabledTest.php

@@ -27,7 +27,7 @@ class EnabledTest extends TestCase
     protected $objectManager;
 
     /**
-     * Payment config mock
+     * Mock object for payment config
      *
      * @var MockObject|Config
      */

app/code/Magento/SalesRule/Test/Unit/Model/Converter/ToModelTest.php

@@ -59,6 +59,9 @@ protected function setUp(): void
         );
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
     public function testDataModelToArray()
     {
         $array = [

app/code/Magento/SalesRule/Test/Unit/Model/Plugin/ResourceModel/RuleTest.php

@@ -41,7 +41,6 @@ protected function setUp(): void
         $objectManager = new ObjectManager($this);
         $this->ruleResource = $this->createMock(RuleResource::class);
         $this->genericClosure = function () {
-            return;
         };
         $this->abstractModel = $this->createMock(AbstractModel::class);
 

app/code/Magento/SalesRule/Test/Unit/Model/Rule/RuleQuoteRecollectTotalsOnDemandTest.php

@@ -43,6 +43,8 @@ protected function setUp(): void
      * Test that multiple updates query are executed on large result
      *
      * @return void
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function testExecute(): void
     {

app/code/Magento/SalesRule/Test/Unit/Model/RulesApplierTest.php

@@ -70,7 +70,7 @@ class RulesApplierTest extends TestCase
     protected $childrenValidationLocator;
 
     /**
-     * RuleDiscountInterfaceFactory|MockObject
+     * @var RuleDiscountInterfaceFactory|MockObject
      */
     protected $ruleDiscountInterfaceFactoryMock;
 

app/code/Magento/SalesSequence/Test/Unit/Model/Sequence/DeleteByStoreTest.php

@@ -91,6 +91,7 @@ protected function setUp(): void
     /**
      * @throws \Exception
      * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function testExecute()
     {