AC-15499: PHPUnit 12: Upgrade Import/Export & Data Management related test cases

Author: shashi011

app/code/Magento/AwsS3/Test/Unit/Driver/AwsS3FactoryTest.php

@@ -64,7 +64,7 @@ class AwsS3FactoryTest extends TestCase
      */
     protected function setUp(): void
     {
-        $this->objectManagerMock = $this->getMockForAbstractClass(ObjectManagerInterface::class);
+        $this->objectManagerMock = $this->createMock(ObjectManagerInterface::class);
         $this->remoteStorageConfigMock = $this->createMock(Config::class);
         $this->metadataFactoryMock = $this->createMock(MetadataProviderInterfaceFactory::class);
         $this->remoteStorageCacheMock = $this->createMock(CacheInterfaceFactory::class);

app/code/Magento/AwsS3/Test/Unit/Driver/AwsS3Test.php

@@ -12,6 +12,7 @@
 use Magento\AwsS3\Driver\AwsS3;
 use Magento\Framework\Exception\FileSystemException;
 use Magento\RemoteStorage\Driver\Adapter\MetadataProviderInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -44,9 +45,9 @@ class AwsS3Test extends TestCase
      */
     protected function setUp(): void
     {
-        $this->adapterMock = $this->getMockForAbstractClass(FilesystemAdapter::class);
-        $this->metadataProviderMock = $this->getMockForAbstractClass(MetadataProviderInterface::class);
-        $loggerMock = $this->getMockForAbstractClass(LoggerInterface::class);
+        $this->adapterMock = $this->createMock(FilesystemAdapter::class);
+        $this->metadataProviderMock = $this->createMock(MetadataProviderInterface::class);
+        $loggerMock = $this->createMock(LoggerInterface::class);
 
         $this->driver = new AwsS3($this->adapterMock, $loggerMock, self::URL, $this->metadataProviderMock);
     }
@@ -55,9 +56,8 @@ protected function setUp(): void
      * @param string|null $basePath
      * @param string|null $path
      * @param string $expected
-     *
-     * @dataProvider getAbsolutePathDataProvider
      */
+    #[DataProvider('getAbsolutePathDataProvider')]
     public function testGetAbsolutePath($basePath, $path, string $expected): void
     {
         self::assertSame($expected, $this->driver->getAbsolutePath($basePath, $path));
@@ -172,9 +172,8 @@ public static function getAbsolutePathDataProvider(): array
      * @param string $basePath
      * @param string $path
      * @param string $expected
-     *
-     * @dataProvider getRelativePathDataProvider
      */
+    #[DataProvider('getRelativePathDataProvider')]
     public function testGetRelativePath(string $basePath, string $path, string $expected): void
     {
         self::assertSame($expected, $this->driver->getRelativePath($basePath, $path));
@@ -214,8 +213,8 @@ public static function getRelativePathDataProvider(): array
      * @param iterable $listContents
      * @param \Exception|null $metadataException
      * @throws FileSystemException
-     * @dataProvider isDirectoryDataProvider
      */
+    #[DataProvider('isDirectoryDataProvider')]
     public function testIsDirectory(
         string $path,
         string $normalizedPath,
@@ -301,9 +300,8 @@ public static function isDirectoryDataProvider(): array
      * @param array $metadata
      * @param bool $expected
      * @throws FileSystemException
-     *
-     * @dataProvider isFileDataProvider
      */
+    #[DataProvider('isFileDataProvider')]
     public function testIsFile(
         string $path,
         string $normalizedPath,
@@ -380,9 +378,8 @@ public static function isFileDataProvider(): array
     /**
      * @param string $path
      * @param string $expected
-     *
-     * @dataProvider getRealPathSafetyDataProvider
      */
+    #[DataProvider('getRealPathSafetyDataProvider')]
     public function testGetRealPathSafety(string $path, string $expected): void
     {
         self::assertSame($expected, $this->driver->getRealPathSafety($path));
@@ -556,9 +553,7 @@ public function testFileCloseShouldReturnFalseIfTheArgumentIsNotAResource(): voi
         $this->assertEquals(false, $this->driver->fileClose(false));
     }
 
-    /**
-     * @dataProvider fileOpenModesDataProvider
-     */
+    #[DataProvider('fileOpenModesDataProvider')]
     public function testFileOppenedMode($mode, $expected): void
     {
         $this->adapterMock->method('fileExists')->willReturn(true);

app/code/Magento/AwsS3/Test/Unit/Driver/CredentialsCacheTest.php

@@ -42,8 +42,7 @@ class CredentialsCacheTest extends TestCase
     protected function setUp(): void
     {
         $this->cacheMock = $this->createMock(CacheInterface::class);
-        $this->credentialsFactory =
-            $this->getMockBuilder(CredentialsFactory::class)->disableOriginalConstructor()->getMock();
+        $this->credentialsFactory = $this->createMock(CredentialsFactory::class);
         $this->jsonMock = $this->createMock(Json::class);
         $this->adapter = new CredentialsCache($this->cacheMock, $this->credentialsFactory, $this->jsonMock);
     }

app/code/Magento/GroupedCatalogInventory/Test/Unit/Plugin/OutOfStockFilterTest.php

@@ -16,6 +16,7 @@
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\GroupedCatalogInventory\Plugin\OutOfStockFilter;
 use Magento\GroupedProduct\Model\Product\Type\Grouped;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -50,15 +51,11 @@ protected function setUp(): void
     {
         $objectManager = new ObjectManager($this);
 
-        $this->subjectMock = $this->getMockBuilder(Grouped::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->subjectMock = $this->createMock(Grouped::class);
 
-        $this->buyRequestMock = $this->getMockBuilder(DataObject::class)
-            ->getMock();
+        $this->buyRequestMock = $this->createMock(DataObject::class);
 
-        $this->stockRegistryMock = $this->getMockBuilder(StockRegistryInterface::class)
-            ->getMock();
+        $this->stockRegistryMock = $this->createMock(StockRegistryInterface::class);
 
         $this->unit = $objectManager->getObject(
             OutOfStockFilter::class,
@@ -73,8 +70,8 @@ protected function setUp(): void
      *
      * @param mixed $nonArrayResult
      * @return void
-     * @dataProvider nonArrayResultsProvider
      */
+    #[DataProvider('nonArrayResultsProvider')]
     public function testFilterOnlyProcessesArray($nonArrayResult): void
     {
         $this->stockRegistryMock->expects($this->never())
@@ -119,8 +116,8 @@ public function testFilterIgnoresResultIfSuperGroupIsPresent(): void
      * @param array|Closure $originalResult
      * @param array $productStockStatusMap
      * @param array $expectedResult
-     * @dataProvider outOfStockProductDataProvider
      */
+    #[DataProvider('outOfStockProductDataProvider')]
     public function testFilterRemovesOutOfStockProducts(
         $originalResult,
         array $productStockStatusMap,
@@ -193,7 +190,7 @@ public static function outOfStockProductDataProvider(): array
      */
     public function createProductMockById(int $id): MockObject|Product
     {
-        $product = $this->getMockBuilder(Product::class)->disableOriginalConstructor()->getMock();
+        $product = $this->createMock(Product::class);
         $product->method('getId')->willReturn($id);
         return $product;
     }
@@ -219,8 +216,6 @@ public static function nonArrayResultsProvider(): array
      */
     private function createProductMock(): MockObject
     {
-        return $this->getMockBuilder(Product::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        return $this->createMock(Product::class);
     }
 }

app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/Grouped/LinksTest.php

@@ -17,6 +17,7 @@
 use Magento\GroupedImportExport\Model\Import\Product\Type\Grouped\Links;
 use Magento\ImportExport\Model\ImportFactory;
 use Magento\ImportExport\Model\ResourceModel\Import\Data;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -84,9 +85,8 @@ public static function linksDataProvider()
 
     /**
      * @param array $linksData
-     *
-     * @dataProvider linksDataProvider
      */
+    #[DataProvider('linksDataProvider')]
     public function testSaveLinksDataNoProductsAttrs($linksData)
     {
         $this->processBehaviorGetter('append');
@@ -98,9 +98,8 @@ public function testSaveLinksDataNoProductsAttrs($linksData)
 
     /**
      * @param array $linksData
-     *
-     * @dataProvider linksDataProvider
      */
+    #[DataProvider('linksDataProvider')]
     public function testSaveLinksDataWithProductsAttrs($linksData)
     {
         $linksData['attr_product_ids'] = [12 => true, 16 => true];
@@ -177,9 +176,8 @@ protected function processAttributeGetter($dbAttributes)
     /**
      * @param array $dbAttributes
      * @param array $returnedAttributes
-     *
-     * @dataProvider attributesDataProvider
      */
+    #[DataProvider('attributesDataProvider')]
     public function testGetAttributes($dbAttributes, $returnedAttributes)
     {
         $this->processAttributeGetter($dbAttributes);

app/code/Magento/GroupedImportExport/Test/Unit/Model/Import/Product/Type/GroupedTest.php

@@ -22,14 +22,17 @@
 use Magento\GroupedImportExport\Model\Import\Product\Type\Grouped;
 use Magento\GroupedImportExport\Model\Import\Product\Type\Grouped\Links;
 use Magento\Catalog\Model\ProductTypes\ConfigInterface;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\ImportExport\Test\Unit\Model\Import\AbstractImportTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class GroupedTest extends AbstractImportTestCase
 {
+    use MockCreationTrait;
     /**
      * @var GroupedImportExport\Model\Import\Product\Type\Grouped
      */
@@ -123,7 +126,7 @@ protected function setUp(): void
             1 => 'grouped'
         ];
         $this->links = $this->createMock(Links::class);
-        $this->configMock = $this->getMockForAbstractClass(ConfigInterface::class);
+        $this->configMock = $this->createMock(ConfigInterface::class);
         $this->configMock->expects($this->once())
             ->method('getComposableTypes')
             ->willReturn(['simple', 'virtual', 'downloadable']);
@@ -133,11 +136,10 @@ protected function setUp(): void
                 'attribute_id' => 'attributeSetName',
             ]
         ];
-        $this->connection = $this->getMockBuilder(Mysql::class)
-            ->addMethods(['joinLeft'])
-            ->onlyMethods(['select', 'fetchAll', 'fetchPairs', 'insertOnDuplicate', 'delete', 'quoteInto'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->connection = $this->createPartialMockWithReflection(
+            Mysql::class,
+            ['select', 'fetchAll', 'fetchPairs', 'insertOnDuplicate', 'delete', 'quoteInto', 'joinLeft']
+        );
         $this->select = $this->createPartialMock(
             Select::class,
             ['from', 'where', 'joinLeft', 'getConnection']
@@ -207,8 +209,8 @@ protected function setUp(): void
      * @param array $bunch
      *
      * @return void
-     * @dataProvider saveDataProvider
      */
+    #[DataProvider('saveDataProvider')]
     public function testSaveData($skus, $bunch): void
     {
         $this->entityModel->expects($this->once())->method('getNewSku')->willReturn($skus['newSku']);

app/code/Magento/ImportExport/Test/Unit/Block/Adminhtml/Export/FilterTest.php

@@ -20,7 +20,10 @@
 use Magento\Framework\View\Element\Html\Select;
 use Magento\Framework\View\Layout;
 use Magento\ImportExport\Block\Adminhtml\Export\Filter;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\ImportExport\Model\ResourceModel\Export\AttributeGridCollectionFactory;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -29,6 +32,7 @@
  */
 class FilterTest extends TestCase
 {
+    use MockCreationTrait;
     /**
      * @var Filter|MockObject
      */
@@ -44,10 +48,13 @@ class FilterTest extends TestCase
      */
     protected function setUp(): void
     {
-        $context = $this->getMockBuilder(Context::class)
-            ->onlyMethods(['getFileSystem', 'getEscaper', 'getLocaleDate', 'getLayout'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $objectManager = new ObjectManager($this);
+        $objectManager->prepareObjectManager();
+
+        $context = $this->createPartialMock(
+            Context::class,
+            ['getFileSystem', 'getEscaper', 'getLocaleDate', 'getLayout']
+        );
         $filesystem = $this->createMock(Filesystem::class);
         $context->expects($this->any())->method('getFileSystem')->willReturn($filesystem);
         $escaper = $this->createPartialMock(Escaper::class, ['escapeHtml']);
@@ -76,16 +83,12 @@ protected function setUp(): void
      * @param array $attributeData
      * @param array $values
      * @param array $expect
-     * @dataProvider dateFilterDataProvider
      */
+    #[DataProvider('dateFilterDataProvider')]
     public function testDateFilter(array $attributeData, array $values, array $expect): void
     {
         $type = Date::class;
-        $block = $block = $this->getMockBuilder($type)
-            ->addMethods(['setValue'])
-            ->onlyMethods(['getHtml'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $block = $this->createPartialMockWithReflection($type, ['getHtml', 'setValue']);
         $block->expects($this->exactly(2))
             ->method('setValue')
             ->willReturnCallback(function (...$expect) use ($block) {
@@ -134,16 +137,13 @@ public static function dateFilterDataProvider(): array
      * @param array $attributeData
      * @param array $values
      * @param array $expect
-     * @dataProvider selectFilterDataProvider
      */
+    #[DataProvider('selectFilterDataProvider')]
     public function testSelectFilter(array $attributeData, array $values, array $expect): void
     {
         $html = '<select></select>';
         $type = Select::class;
-        $block = $block = $this->getMockBuilder($type)
-            ->onlyMethods(['getHtml'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $block = $this->createPartialMock($type, ['getHtml']);
         $block->expects($this->once())
             ->method('getHtml')
             ->willReturn($html);
@@ -228,8 +228,8 @@ public static function selectFilterDataProvider(): array
      * @param array $attributeData
      * @param array $values
      * @param array $expect
-     * @dataProvider inputFilterDataProvider
      */
+    #[DataProvider('inputFilterDataProvider')]
     public function testInputFilter(array $attributeData, array $values, array $expect): void
     {
         $this->layout->expects($this->never())
@@ -276,8 +276,8 @@ public static function inputFilterDataProvider(): array
      * @param array $attributeData
      * @param array $values
      * @param array $expect
-     * @dataProvider numberFilterDataProvider
      */
+    #[DataProvider('numberFilterDataProvider')]
     public function testNumberFilter(array $attributeData, array $values, array $expect): void
     {
         $this->layout->expects($this->never())
@@ -320,9 +320,7 @@ public static function numberFilterDataProvider(): array
      */
     private function getAttributeMock(array $data): Attribute
     {
-        $attribute = $this->getMockBuilder(Attribute::class)
-            ->disableOriginalConstructor()
-            ->getMockForAbstractClass();
+        $attribute = $this->createPartialMock(Attribute::class, []);
 
         $attribute->addData($data);