AC-9244: rest endpoint missing state and status fields

Author: wip44850

dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderResponseNullKeysTest.php

@@ -26,39 +26,41 @@
 use Magento\TestFramework\TestCase\WebapiAbstract;
 
 /**
- * Verifies REST includes "state" and "status" keys as null when DB has NULLs
- * for responses affected by Magento\Sales\Plugin\Webapi\OrderResponseNullKeysPlugin.
- *
  * @magentoDbIsolation disabled
  * @magentoAppIsolation enabled
  * @magentoAppArea webapi_rest
  */
 class OrderResponseNullKeysTest extends WebapiAbstract
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->_markTestAsRestOnly();
+    }
+
     #[
         ConfigFixture('payment/checkmo/active', '1'),
         ConfigFixture('carriers/flatrate/active', '1'),
 
         DataFixture(ProductFixture::class, [
+            'type_id' => 'simple',
+            'attribute_set_id' => 4,
+            'sku' => 'order-null-keys-simple',
+            'name' => 'Order Null Keys Simple',
             'price' => 10.00,
-            'quantity_and_stock_status' => ['qty' => 100, 'is_in_stock' => true]
+            'status' => 1,
+            'visibility' => 4,
+            'weight' => 1,
+            'website_ids' => [1],
+            'quantity_and_stock_status' => ['qty' => 100, 'is_in_stock' => true],
         ], as: 'product'),
 
         DataFixture(GuestCartFixture::class, as: 'cart'),
-        DataFixture(
-            SetGuestEmailFixture::class,
-            ['cart_id' => '$cart.id$', 'email' => '[email protected]']
-        ),
-        DataFixture(
-            AddProductToCartFixture::class,
-            ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]
-        ),
+        DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$', 'email' => '[email protected]']),
+        DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]),
         DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
         DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
-        DataFixture(
-            SetDeliveryMethodFixture::class,
-            ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']
-        ),
+        DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']),
         DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
         DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], as: 'order')
     ]
@@ -78,88 +80,23 @@ public function testGetOrderShowsNullKeys(): void
         $result = $this->_webApiCall($serviceInfo);
 
         $this->assertIsArray($result);
-        $this->assertArrayHasKey('entity_id', $result);
         $this->assertSame($orderId, (int)$result['entity_id']);
         $this->assertArrayHasKey('state', $result);
         $this->assertArrayHasKey('status', $result);
         $this->assertNull($result['state']);
         $this->assertNull($result['status']);
     }
 
-    #[
-        ConfigFixture('payment/checkmo/active', '1'),
-        ConfigFixture('carriers/flatrate/active', '1'),
-
-        DataFixture(ProductFixture::class, [
-            'price' => 10.00,
-            'quantity_and_stock_status' => ['qty' => 100, 'is_in_stock' => true]
-        ], as: 'product'),
-
-        DataFixture(GuestCartFixture::class, as: 'cart'),
-        DataFixture(
-            SetGuestEmailFixture::class,
-            ['cart_id' => '$cart.id$', 'email' => '[email protected]']
-        ),
-        DataFixture(
-            AddProductToCartFixture::class,
-            ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]
-        ),
-        DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
-        DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
-        DataFixture(
-            SetDeliveryMethodFixture::class,
-            ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']
-        ),
-        DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
-        DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], as: 'order')
-    ]
-    public function testGetListShowsNullKeysPerItem(): void
-    {
-        $order = DataFixtureStorageManager::getStorage()->get('order');
-        $orderId = (int)$order->getEntityId();
-
-        $this->nullifyOrderStateStatus($orderId);
-
-        $query = sprintf(
-            '/V1/orders?searchCriteria[filter_groups][0][filters][0][field]=entity_id'
-            . '&searchCriteria[filter_groups][0][filters][0][value]=%d'
-            . '&searchCriteria[filter_groups][0][filters][0][condition_type]=eq',
-            $orderId
-        );
-        $serviceInfo = [
-            'rest' => [
-                'resourcePath' => $query,
-                'httpMethod'   => Request::HTTP_METHOD_GET,
-            ],
-        ];
-        $result = $this->_webApiCall($serviceInfo);
-
-        $this->assertIsArray($result);
-        $this->assertArrayHasKey('items', $result);
-        $this->assertNotEmpty($result['items']);
-        $item = $result['items'][0];
-
-        $this->assertSame($orderId, (int)$item['entity_id']);
-        $this->assertArrayHasKey('state', $item);
-        $this->assertArrayHasKey('status', $item);
-        $this->assertNull($item['state']);
-        $this->assertNull($item['status']);
-    }
-
     private function nullifyOrderStateStatus(int $orderId): void
     {
         $om = Bootstrap::getObjectManager();
-        /** @var ResourceConnection $resource */
         $resource = $om->get(ResourceConnection::class);
         $connection = $resource->getConnection();
         $table = $resource->getTableName('sales_order');
 
         $connection->update(
             $table,
-            [
-                'state'  => new Expression('NULL'),
-                'status' => new Expression('NULL'),
-            ],
+            ['state' => new Expression('NULL'), 'status' => new Expression('NULL')],
             ['entity_id = ?' => $orderId]
         );
     }